Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: build/android/gyp/write_ordered_libraries.py

Issue 2634563002: android_webview: support building a stub WebView. (Closed)
Patch Set: add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/write_ordered_libraries.py
diff --git a/build/android/gyp/write_ordered_libraries.py b/build/android/gyp/write_ordered_libraries.py
index f656adfe30aca472a6ea6ee1f96c4032e17dbc78..4765878142c6901425c06bd9d7547b0c88f11e30 100755
--- a/build/android/gyp/write_ordered_libraries.py
+++ b/build/android/gyp/write_ordered_libraries.py
@@ -102,6 +102,8 @@ def main():
help='A list of top-level input libraries.')
parser.add_option('--libraries-dir',
help='The directory which contains shared libraries.')
+ parser.add_option('--unpackaged-libraries',
+ help='List of additional libraries to load that are not in the APK.')
parser.add_option('--readelf', help='Path to the readelf binary.')
parser.add_option('--output', help='Path to the generated .json file.')
parser.add_option('--stamp', help='Path to touch on success.')
@@ -114,10 +116,15 @@ def main():
libraries = build_utils.ParseGnList(options.input_libraries)
if len(libraries):
libraries = GetSortedTransitiveDependenciesForBinaries(libraries)
+ if options.unpackaged_libraries:
+ unpackaged_libraries = build_utils.ParseGnList(options.unpackaged_libraries)
+ else:
+ unpackaged_libraries = []
# Convert to "base" library names: e.g. libfoo.so -> foo
+ all_libraries = libraries + unpackaged_libraries
michaelbai 2017/01/18 22:59:21 Is all_libraries actually used?
Torne 2017/01/19 14:23:12 Yes, on the changed line immediately below, to gen
java_libraries_list = (
- '{%s}' % ','.join(['"%s"' % s[3:-3] for s in libraries]))
+ '{%s}' % ','.join(['"%s"' % s[3:-3] for s in all_libraries]))
out_json = {
'libraries': libraries,

Powered by Google App Engine
This is Rietveld 408576698