Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2634543003: Fix physical_file_system_test.dart on Windows. (Closed)

Created:
3 years, 11 months ago by Paul Berry
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix physical_file_system_test.dart on Windows. With the simplification to PhysicalFileSystem introduced in fef4569eb5a80c72b1f7b89dfac96cd78f2b19cf, the URI "/foo.dart" is now uniformly treated as equivalent to "file:///foo.dart", even on Windows. (At the time the file is read, the file will be located on the current drive). This is consistent with what we do for relative paths. TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/577c91ba27f4c384d063b2d4703876c0e8106003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/test/physical_file_system_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 577c91ba27f4c384d063b2d4703876c0e8106003 (presubmit successful).
3 years, 11 months ago (2017-01-13 13:51:07 UTC) #2
Siggi Cherem (dart-lang)
3 years, 11 months ago (2017-01-13 16:01:41 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698