Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 263453007: Implement "Save image as" for canvas (chromium side). (Closed) Base URL: http://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index 46198075e9717bb45783b16d83a1449bc3eaa0a6..bf786a16b6735f2518eebedb3890914c56741406 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -57,7 +57,7 @@ void BeginDownload(scoped_ptr<DownloadUrlParameters> params,
scoped_ptr<net::URLRequest> request(
params->resource_context()->GetRequestContext()->CreateRequest(
params->url(), net::DEFAULT_PRIORITY, NULL, NULL));
- request->SetLoadFlags(request->load_flags() | params->load_flags());
+ //request->SetLoadFlags(request->load_flags() | params->load_flags());
Justin Novosad 2014/04/30 15:07:16 Why was this commented out?
request->set_method(params->method());
if (!params->post_body().empty()) {
const std::string& body = params->post_body();
@@ -114,11 +114,13 @@ void BeginDownload(scoped_ptr<DownloadUrlParameters> params,
scoped_ptr<DownloadSaveInfo> save_info(new DownloadSaveInfo());
save_info->file_path = params->file_path();
- save_info->suggested_name = params->suggested_name();
+save_info->prompt_for_save_location = params->prompt();
+
+/* save_info->suggested_name = params->suggested_name();
save_info->offset = params->offset();
save_info->hash_state = params->hash_state();
save_info->prompt_for_save_location = params->prompt();
- save_info->file = params->GetFile();
+ save_info->file = params->GetFile();*/
Avi (use Gerrit) 2014/04/30 14:52:28 ? We don't commit commented-out code.
ResourceDispatcherHost::Get()->BeginDownload(
request.Pass(),

Powered by Google App Engine
This is Rietveld 408576698