Implement "Save image as" for canvas (chromium side).

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 612 matching lines @@
           ContextMenuContentType::ITEM_GROUP_MEDIA_VIDEO)) {
     AppendVideoItems();
   }
 
   if (content_type_->SupportsGroup(
           ContextMenuContentType::ITEM_GROUP_MEDIA_AUDIO)) {
     AppendAudioItems();
   }
 
   if (content_type_->SupportsGroup(
+          ContextMenuContentType::ITEM_GROUP_MEDIA_CANVAS)) {
+    AppendCanvasItems();
+  }
+
+  if (content_type_->SupportsGroup(
           ContextMenuContentType::ITEM_GROUP_MEDIA_PLUGIN)) {
     AppendPluginItems();
   }
 
   // ITEM_GROUP_MEDIA_FILE has no specific items.
 
   if (content_type_->SupportsGroup(ContextMenuContentType::ITEM_GROUP_EDITABLE))
     AppendEditableItems();
 
   if (content_type_->SupportsGroup(ContextMenuContentType::ITEM_GROUP_COPY)) {
@@ skipping 193 matching lines @@
   AppendMediaItems();
   menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVEAVAS,
                                   IDS_CONTENT_CONTEXT_SAVEAUDIOAS);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_COPYAVLOCATION,
                                   IDS_CONTENT_CONTEXT_COPYAUDIOLOCATION);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_OPENAVNEWTAB,
                                   IDS_CONTENT_CONTEXT_OPENAUDIONEWTAB);
 }
 
+void RenderViewContextMenu::AppendCanvasItems() {
+  menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVEIMAGEAS,
+                                  IDS_CONTENT_CONTEXT_SAVEIMAGEAS);
+
+  // FIXME: We should support 'copy image' for canvas.

[Avi (use Gerrit), 2014/04/30 14:52:28]

Chromium style is:

// TODO(zino): We should support 'copy image' for canvas.

[Justin Novosad, 2014/04/30 15:07:16]

You should also file a bug for this so we don't forget about it, and you can
reference the bug in this comment

+}
+
 void RenderViewContextMenu::AppendVideoItems() {
   AppendMediaItems();
   menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVEAVAS,
                                   IDS_CONTENT_CONTEXT_SAVEVIDEOAS);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_COPYAVLOCATION,
                                   IDS_CONTENT_CONTEXT_COPYVIDEOLOCATION);
   menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_OPENAVNEWTAB,
                                   IDS_CONTENT_CONTEXT_OPENVIDEONEWTAB);
 }
@@ skipping 362 matching lines @@
           ProfileIOData::IsHandledProtocol(params_.link_url.scheme());
     }
 
     case IDC_CONTENT_CONTEXT_SAVEIMAGEAS: {
       PrefService* local_state = g_browser_process->local_state();
       DCHECK(local_state);
       // Test if file-selection dialogs are forbidden by policy.
       if (!local_state->GetBoolean(prefs::kAllowFileSelectionDialogs))
         return false;
 
+      if (params_.media_type == WebContextMenuData::MediaTypeCanvas)
+        return true;
+
       return params_.src_url.is_valid() &&
           ProfileIOData::IsHandledProtocol(params_.src_url.scheme());
     }
 
     // The images shown in the most visited thumbnails can't be opened or
     // searched for conventionally.
     case IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB:
     case IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE:
       return params_.src_url.is_valid() &&
           (params_.src_url.scheme() != content::kChromeUIScheme);
@@ skipping 292 matching lines @@
       dl_params->set_referrer(
           content::Referrer(referrer, params_.referrer_policy));
       dl_params->set_referrer_encoding(params_.frame_charset);
       dl_params->set_prompt(true);
       dlm->DownloadUrl(dl_params.Pass());
       break;
     }
 
     case IDC_CONTENT_CONTEXT_SAVEAVAS:
     case IDC_CONTENT_CONTEXT_SAVEIMAGEAS: {
-      RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
-      const GURL& referrer =
-          params_.frame_url.is_empty() ? params_.page_url : params_.frame_url;
-      const GURL& url = params_.src_url;
-      source_web_contents_->SaveFrame(url, content::Referrer(
-          referrer, params_.referrer_policy));
+      if (params_.media_type == WebContextMenuData::MediaTypeCanvas) {
+        source_web_contents_->GetRenderViewHost()->SaveImageAt(
+          params_.x, params_.y);
+      } else {
+        // FIXME: We can use SaveImageAt() like a case of canvas.

[Avi (use Gerrit), 2014/04/30 14:52:28]

TODO again. And I do look forward to your fix to make this other code cleaner :)

+        RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
+        const GURL& referrer =
+            params_.frame_url.is_empty() ? params_.page_url : params_.frame_url;
+        const GURL& url = params_.src_url;
+        source_web_contents_->SaveFrame(url, content::Referrer(
+            referrer, params_.referrer_policy));
+      }
       break;
     }
 
     case IDC_CONTENT_CONTEXT_COPYLINKLOCATION:
       WriteURLToClipboard(params_.unfiltered_link_url);
       break;
 
     case IDC_CONTENT_CONTEXT_COPYIMAGELOCATION:
     case IDC_CONTENT_CONTEXT_COPYAVLOCATION:
       WriteURLToClipboard(params_.src_url);
@@ skipping 465 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }