Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: chrome/app/chrome_main_delegate.cc

Issue 263453002: Revert r262011, which disabled support for resources in chrome.dll. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/chrome_main_delegate.h" 5 #include "chrome/app/chrome_main_delegate.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/cpu.h" 8 #include "base/cpu.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 22 matching lines...) Expand all
33 #include "chrome/plugin/chrome_content_plugin_client.h" 33 #include "chrome/plugin/chrome_content_plugin_client.h"
34 #include "chrome/renderer/chrome_content_renderer_client.h" 34 #include "chrome/renderer/chrome_content_renderer_client.h"
35 #include "chrome/utility/chrome_content_utility_client.h" 35 #include "chrome/utility/chrome_content_utility_client.h"
36 #include "components/nacl/common/nacl_switches.h" 36 #include "components/nacl/common/nacl_switches.h"
37 #include "components/startup_metric_utils/startup_metric_utils.h" 37 #include "components/startup_metric_utils/startup_metric_utils.h"
38 #include "content/public/common/content_client.h" 38 #include "content/public/common/content_client.h"
39 #include "content/public/common/content_paths.h" 39 #include "content/public/common/content_paths.h"
40 #include "ui/base/ui_base_switches.h" 40 #include "ui/base/ui_base_switches.h"
41 41
42 #if defined(OS_WIN) 42 #if defined(OS_WIN)
43 #include <atlbase.h>
43 #include <malloc.h> 44 #include <malloc.h>
44 #include <algorithm> 45 #include <algorithm>
45 #include "base/strings/string_util.h" 46 #include "base/strings/string_util.h"
46 #include "chrome/common/child_process_logging.h" 47 #include "chrome/common/child_process_logging.h"
47 #include "sandbox/win/src/sandbox.h" 48 #include "sandbox/win/src/sandbox.h"
48 #include "tools/memory_watcher/memory_watcher.h" 49 #include "tools/memory_watcher/memory_watcher.h"
49 #include "ui/base/resource/resource_bundle_win.h" 50 #include "ui/base/resource/resource_bundle_win.h"
50 #endif 51 #endif
51 52
52 #if defined(OS_MACOSX) 53 #if defined(OS_MACOSX)
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 #if !defined(OS_ANDROID) 673 #if !defined(OS_ANDROID)
673 // Android does InitLogging when library is loaded. Skip here. 674 // Android does InitLogging when library is loaded. Skip here.
674 logging::OldFileDeletionState file_state = 675 logging::OldFileDeletionState file_state =
675 logging::APPEND_TO_OLD_LOG_FILE; 676 logging::APPEND_TO_OLD_LOG_FILE;
676 if (process_type.empty()) { 677 if (process_type.empty()) {
677 file_state = logging::DELETE_OLD_LOG_FILE; 678 file_state = logging::DELETE_OLD_LOG_FILE;
678 } 679 }
679 logging::InitChromeLogging(command_line, file_state); 680 logging::InitChromeLogging(command_line, file_state);
680 #endif 681 #endif
681 682
683 #if defined(OS_WIN)
684 // TODO(zturner): Throbber icons are still stored in chrome.dll, this can be
685 // killed once those are merged into resources.pak. See
686 // GlassBrowserFrameView::InitThrobberIcons() and http://crbug.com/368327.
687 ui::SetResourcesDataDLL(_AtlBaseModule.GetResourceInstance());
688 #endif
689
682 if (SubprocessNeedsResourceBundle(process_type)) { 690 if (SubprocessNeedsResourceBundle(process_type)) {
683 // Initialize ResourceBundle which handles files loaded from external 691 // Initialize ResourceBundle which handles files loaded from external
684 // sources. The language should have been passed in to us from the 692 // sources. The language should have been passed in to us from the
685 // browser process as a command line flag. 693 // browser process as a command line flag.
686 #if defined(DISABLE_NACL) 694 #if defined(DISABLE_NACL)
687 DCHECK(command_line.HasSwitch(switches::kLang) || 695 DCHECK(command_line.HasSwitch(switches::kLang) ||
688 process_type == switches::kZygoteProcess || 696 process_type == switches::kZygoteProcess ||
689 process_type == switches::kGpuProcess || 697 process_type == switches::kGpuProcess ||
690 process_type == switches::kPpapiBrokerProcess || 698 process_type == switches::kPpapiBrokerProcess ||
691 process_type == switches::kPpapiPluginProcess); 699 process_type == switches::kPpapiPluginProcess);
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 } 910 }
903 911
904 content::ContentUtilityClient* 912 content::ContentUtilityClient*
905 ChromeMainDelegate::CreateContentUtilityClient() { 913 ChromeMainDelegate::CreateContentUtilityClient() {
906 #if defined(CHROME_MULTIPLE_DLL_BROWSER) 914 #if defined(CHROME_MULTIPLE_DLL_BROWSER)
907 return NULL; 915 return NULL;
908 #else 916 #else
909 return g_chrome_content_utility_client.Pointer(); 917 return g_chrome_content_utility_client.Pointer();
910 #endif 918 #endif
911 } 919 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698