Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2634493007: Introduce LayoutObject::AncestorSkipInfo. (Closed)
Patch Set: Turn AncestorSkipInfo into a proper class with private data members. Only look for filters when tol… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index ceda19d736df198810bb3f7c2d9de80fdc95a461..1f570c9a94dbdc9c760123bacc58fca5610fbae1 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2328,10 +2328,8 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(
if (ancestor == this)
return true;
- bool ancestorSkipped;
- bool filterSkipped;
- LayoutObject* container =
- this->container(ancestor, &ancestorSkipped, &filterSkipped);
+ AncestorSkipInfo skipInfo(ancestor, true);
+ LayoutObject* container = this->container(&skipInfo);
LayoutBox* tableRowContainer = nullptr;
// Skip table row because cells and rows are in the same coordinate space (see
// below, however for more comments about when |ancestor| is the table row).
@@ -2345,7 +2343,7 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(
if (!container)
return true;
- if (filterSkipped)
+ if (skipInfo.filterSkipped())
inflateVisualRectForFilterUnderContainer(rect, *container, ancestor);
// We are now in our parent container's coordinate space. Apply our transform
@@ -2401,7 +2399,7 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(
rect, visualRectFlags))
return false;
- if (ancestorSkipped) {
+ if (skipInfo.ancestorSkipped()) {
// If the ancestor is below the container, then we need to map the rect into
// ancestor's coordinates.
LayoutSize containerOffset =
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698