Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: services/service_manager/public/cpp/lib/service_context.cc

Issue 2634493002: Revert of Perform InterfaceProviderSpec intersection in the ServiceManager (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/lib/service_context.cc
diff --git a/services/service_manager/public/cpp/lib/service_context.cc b/services/service_manager/public/cpp/lib/service_context.cc
index ed133376401f373aead11d7de47b264fc4b39d5d..88074a776d8e3009e4472ad145ce6ebeecc7ef8a 100644
--- a/services/service_manager/public/cpp/lib/service_context.cc
+++ b/services/service_manager/public/cpp/lib/service_context.cc
@@ -98,45 +98,13 @@
local_info_.interface_provider_specs, &target_spec);
GetInterfaceProviderSpec(mojom::kServiceManager_ConnectorSpec,
source_info.interface_provider_specs, &source_spec);
-
- // Acknowledge the request regardless of whether it's accepted.
- callback.Run();
-
- CallOnConnect(source_info, source_spec, target_spec, std::move(interfaces));
-}
-
-void ServiceContext::OnBindInterface(
- const ServiceInfo& source_info,
- const std::string& interface_name,
- mojo::ScopedMessagePipeHandle interface_pipe,
- const OnBindInterfaceCallback& callback) {
- // Acknowledge the request regardless of whether it's accepted.
- callback.Run();
-
- mojom::InterfaceProviderPtr interface_provider;
- // TODO(beng): This should be replaced with a call to OnBindInterface() in a
- // subsequent change.
- InterfaceProviderSpec source_spec, target_spec;
- GetInterfaceProviderSpec(mojom::kServiceManager_ConnectorSpec,
- local_info_.interface_provider_specs, &target_spec);
- GetInterfaceProviderSpec(mojom::kServiceManager_ConnectorSpec,
- source_info.interface_provider_specs, &source_spec);
- CallOnConnect(source_info, source_spec, target_spec,
- MakeRequest(&interface_provider));
- interface_provider->GetInterface(interface_name, std::move(interface_pipe));
-}
-
-////////////////////////////////////////////////////////////////////////////////
-// ServiceContext, private:
-
-void ServiceContext::CallOnConnect(const ServiceInfo& source_info,
- const InterfaceProviderSpec& source_spec,
- const InterfaceProviderSpec& target_spec,
- mojom::InterfaceProviderRequest interfaces) {
auto registry =
base::MakeUnique<InterfaceRegistry>(mojom::kServiceManager_ConnectorSpec);
registry->Bind(std::move(interfaces), local_info_.identity, target_spec,
source_info.identity, source_spec);
+
+ // Acknowledge the request regardless of whether it's accepted.
+ callback.Run();
if (!service_->OnConnect(source_info, registry.get()))
return;
@@ -148,6 +116,9 @@
connection_interface_registries_.insert(
std::make_pair(raw_registry, std::move(registry)));
}
+
+////////////////////////////////////////////////////////////////////////////////
+// ServiceContext, private:
void ServiceContext::OnConnectionError() {
// Note that the Service doesn't technically have to quit now, it may live
« no previous file with comments | « services/service_manager/public/cpp/lib/interface_registry.cc ('k') | services/service_manager/public/cpp/service_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698