Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2634463002: Make ddc legacy loader more defensive (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
Reviewers:
Alan Knight, Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make ddc legacy loader more defensive This should match what we need internally. R=alanknight@google.com, jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/f710e7209a9e35df0006a24c12afccae857643e3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M pkg/dev_compiler/lib/js/legacy/dart_library.js View 1 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vsm
3 years, 11 months ago (2017-01-13 00:06:24 UTC) #3
Jacob
lgtm https://codereview.chromium.org/2634463002/diff/1/pkg/dev_compiler/lib/js/legacy/dart_library.js File pkg/dev_compiler/lib/js/legacy/dart_library.js (right): https://codereview.chromium.org/2634463002/diff/1/pkg/dev_compiler/lib/js/legacy/dart_library.js#newcode128 pkg/dev_compiler/lib/js/legacy/dart_library.js:128: } else { missing periods at the end ...
3 years, 11 months ago (2017-01-13 00:48:18 UTC) #4
Alan Knight
lgtm
3 years, 11 months ago (2017-01-13 01:02:14 UTC) #5
vsm
Committed patchset #2 (id:20001) manually as f710e7209a9e35df0006a24c12afccae857643e3 (presubmit successful).
3 years, 11 months ago (2017-01-13 16:02:03 UTC) #7
vsm
3 years, 11 months ago (2017-01-13 16:02:20 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/2634463002/diff/1/pkg/dev_compiler/lib/js/leg...
File pkg/dev_compiler/lib/js/legacy/dart_library.js (right):

https://codereview.chromium.org/2634463002/diff/1/pkg/dev_compiler/lib/js/leg...
pkg/dev_compiler/lib/js/legacy/dart_library.js:128: } else {
On 2017/01/13 00:48:17, Jacob wrote:
> missing periods at the end of comments.

Done.

Powered by Google App Engine
This is Rietveld 408576698