Fasta infrastructure.

Fasta infrastructure.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a1b575a1715694f465f98c12b3ed8d754eba4ec

[ahe, 2017-01-13 12:19:58]

ahe@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2017-01-16 09:47:46]

lgtm

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/command_l...
File pkg/fasta/lib/src/command_line.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/command_l...
pkg/fasta/lib/src/command_line.dart:51: static ParsedArguments
parse(List<String> arguments,
Add doc, especially for the semantics of [specification].

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
File pkg/fasta/lib/src/compiler_command_line.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:58: return options["-o"] ??
options["-o"] ?? defaultOutput;
Second `options["-o"]` should be `options["--output"]`.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:88: summary = "Runs a Dart
program.";
'Compiles and runs' or 'Runs from .dill' or ... ?

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:122: arguments.
Arguments for what?

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/errors.dart
File pkg/fasta/lib/src/errors.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/errors.da...
pkg/fasta/lib/src/errors.dart:55: String message = red("Error:
${safeToString(error)}");
Should use of colors be optional. Windows command line doesn't understand them.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/outline.dart
File pkg/fasta/lib/src/outline.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/outline.d...
pkg/fasta/lib/src/outline.dart:46: return await doOutline(cl, new
Ticker(isVerbose:cl.verbose), cl.output);
`isVerbose:cl.verbose` -> `isVerbose: cl.verbose`

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/run.dart
File pkg/fasta/lib/src/run.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/run.dart#...
pkg/fasta/lib/src/run.dart:31: await TestContext.create(null, <String,
String>{}, constructor);
Add comment that this is to fetch the [dartVm] value.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/translate...
File pkg/fasta/lib/src/translate_uri.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/translate...
pkg/fasta/lib/src/translate_uri.dart:60: "dart:html_common":
"dart-sdk/sdk/lib/html/html_common/html_common_dart2js.dart",
Long lines

[ahe, 2017-01-16 12:07:04]

Thank you, Johnni!

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/command_l...
File pkg/fasta/lib/src/command_line.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/command_l...
pkg/fasta/lib/src/command_line.dart:51: static ParsedArguments
parse(List<String> arguments,
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Add doc, especially for the semantics of [specification].

Done.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
File pkg/fasta/lib/src/compiler_command_line.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:58: return options["-o"] ??
options["-o"] ?? defaultOutput;
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Second `options["-o"]` should be `options["--output"]`.

Done.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:88: summary = "Runs a Dart
program.";
On 2017/01/16 09:47:46, Johnni Winther wrote:
> 'Compiles and runs' or 'Runs from .dill' or ... ?

It compiles and run. But is it important for a usage message to mention that?

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/compiler_...
pkg/fasta/lib/src/compiler_command_line.dart:122: arguments.
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Arguments for what?

Changed to: ... is assumed to be file names or arguments to the Dart program.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/errors.dart
File pkg/fasta/lib/src/errors.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/errors.da...
pkg/fasta/lib/src/errors.dart:55: String message = red("Error:
${safeToString(error)}");
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Should use of colors be optional. Windows command line doesn't understand
them.

Yes. Added a TODO.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/outline.dart
File pkg/fasta/lib/src/outline.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/outline.d...
pkg/fasta/lib/src/outline.dart:46: return await doOutline(cl, new
Ticker(isVerbose:cl.verbose), cl.output);
On 2017/01/16 09:47:46, Johnni Winther wrote:
> `isVerbose:cl.verbose` -> `isVerbose: cl.verbose`

Done.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/run.dart
File pkg/fasta/lib/src/run.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/run.dart#...
pkg/fasta/lib/src/run.dart:31: await TestContext.create(null, <String,
String>{}, constructor);
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Add comment that this is to fetch the [dartVm] value.

Done.

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/translate...
File pkg/fasta/lib/src/translate_uri.dart (right):

https://codereview.chromium.org/2634453004/diff/1/pkg/fasta/lib/src/translate...
pkg/fasta/lib/src/translate_uri.dart:60: "dart:html_common":
"dart-sdk/sdk/lib/html/html_common/html_common_dart2js.dart",
On 2017/01/16 09:47:46, Johnni Winther wrote:
> Long lines

Removed, not used anymore.

[ahe, 2017-01-16 12:07:27]

Patchset #2 (id:20001) has been deleted

[ahe, 2017-01-16 12:08:10]

Description was changed from

==========
Fasta infrastructure.
==========

to

==========
Fasta infrastructure.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8a1b575a1715694f465f98c12b3ed8d754eba4ec
==========

[ahe, 2017-01-16 12:08:21]

Committed patchset #2 (id:40001) manually as
8a1b575a1715694f465f98c12b3ed8d754eba4ec (presubmit successful).