Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2634433002: Skip fewer tests (Closed)

Created:
3 years, 11 months ago by vsm
Modified:
3 years, 11 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More test refactoring to catch failures Skip fewer tests. Many are now passing. Mark the rest as fail and test that they're still failing. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/1f5562e29c917fa5f21944d80bde86dc687da3b1

Patch Set 1 #

Patch Set 2 : Mark a few more passing #

Patch Set 3 : Add comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -281 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 1 2 10 chunks +277 lines, -281 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 11 months ago (2017-01-12 21:18:48 UTC) #3
Bob Nystrom
LGTM! https://codereview.chromium.org/2634433002/diff/40001/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2634433002/diff/40001/pkg/dev_compiler/test/browser/language_tests.js#newcode718 pkg/dev_compiler/test/browser/language_tests.js:718: // we wait for that the complete. If ...
3 years, 11 months ago (2017-01-13 02:19:53 UTC) #4
vsm
3 years, 11 months ago (2017-01-13 17:02:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1f5562e29c917fa5f21944d80bde86dc687da3b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698