Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/user_prefs/tracked/device_id.h

Issue 2634403002: Use GetDeterministicMachineSpecificId instead of RLZ for device_id (Closed)
Patch Set: Add some saftey checks and a histogram for the device_id generation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/device_id.h
diff --git a/components/user_prefs/tracked/device_id.h b/components/user_prefs/tracked/device_id.h
index 2d6d1b8e8b6d0228d19e517ec115b57f4959c564..e9d8d0cf55480f54f815415e5bd15a6a2fd812df 100644
--- a/components/user_prefs/tracked/device_id.h
+++ b/components/user_prefs/tracked/device_id.h
@@ -7,11 +7,14 @@
#include <string>
-enum class MachineIdStatus {
+// Used for UMA, do not reorder.
+enum MachineIdStatus {
SUCCESS = 0,
- FAILURE, // Returned if attempt to obtain a machine-specific ID fails.
- NOT_IMPLEMENTED // Returned if the method for obtaining a machine-specific ID
- // is not implemented for the system.
+ FAILURE, // Returned if attempt to obtain a machine-specific ID fails.
+ NOT_IMPLEMENTED, // Returned if not implemented for the current platform.
+
+ // Add new values before this one.
+ NUM_STATUS
};
// Populates |machine_id| with a deterministic ID for this machine. |machine_id|

Powered by Google App Engine
This is Rietveld 408576698