Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 2634403002: Use GetDeterministicMachineSpecificId instead of RLZ for device_id (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prefs/profile_pref_store_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/chrome_pref_service_factory.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc
index b15a2f10fde75db9eba75ea7a4f3c59de0fe115f..66fd6b285d554d6be0ae2f0b89630ba225e82bf4 100644
--- a/chrome/browser/prefs/chrome_pref_service_factory.cc
+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc
@@ -380,7 +380,7 @@ void HandleReadError(const base::FilePath& pref_filename,
std::unique_ptr<ProfilePrefStoreManager> CreateProfilePrefStoreManager(
const base::FilePath& profile_path) {
- std::string device_id;
+ std::string legacy_device_id;
#if defined(OS_WIN) && BUILDFLAG(ENABLE_RLZ)
// This is used by
// chrome/browser/extensions/api/music_manager_private/device_id_win.cc
@@ -388,7 +388,7 @@ std::unique_ptr<ProfilePrefStoreManager> CreateProfilePrefStoreManager(
// not available synchronously.
// As part of improving pref metrics on other platforms we may want to find
// ways to defer preference loading until the device ID can be used.
- rlz_lib::GetMachineId(&device_id);
+ rlz_lib::GetMachineId(&legacy_device_id);
#endif
std::string seed;
#if defined(GOOGLE_CHROME_BUILD)
@@ -397,7 +397,7 @@ std::unique_ptr<ProfilePrefStoreManager> CreateProfilePrefStoreManager(
#endif
return base::MakeUnique<ProfilePrefStoreManager>(
profile_path, GetTrackingConfiguration(), kTrackedPrefsReportingIDsCount,
- seed, device_id, g_browser_process->local_state());
+ seed, legacy_device_id, g_browser_process->local_state());
}
void PrepareFactory(sync_preferences::PrefServiceSyncableFactory* factory,
« no previous file with comments | « no previous file | chrome/browser/prefs/profile_pref_store_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698