Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 2634353002: Update isolate documentation for addOnExitListener and ping. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index 1cc9d8e32ca6d9ac03cf3ad5f34ca12c0966695f..5e3fe7f648a1972edc11a563e465d9f00d5d8ca6 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -389,7 +389,9 @@ class Isolate {
* message, using the last response value that was added.
*
* If the isolate is already dead, no message will be sent.
- * If `response` cannot be sent to the isolate, then the request is ignored.
+ *
+ * The [response] object must follow the same restrictions as enforced by
+ * [SendPort.send].
* It is recommended to only use simple values that can be sent to all
* isolates, like `null`, booleans, numbers or strings.
*
@@ -464,6 +466,11 @@ class Isolate {
/**
* Request that the isolate send [response] on the [responsePort].
*
+ * The [response] object must follow the same restrictions as enforced by
+ * [SendPort.send].
+ * It is recommended to only use simple values that can be sent to all
+ * isolates, like `null`, booleans, numbers or strings.
+ *
* If the isolate is alive, it will eventually send `response`
* (defaulting to `null`) on the response port.
*
@@ -478,10 +485,6 @@ class Isolate {
* control returns to the event loop of the receiving isolate,
* after the current event, and any already scheduled control events,
* are completed.
- *
- * If `response` cannot be sent to the isolate, then the request is ignored.
- * It is recommended to only use simple values that can be sent to all
- * isolates, like `null`, booleans, numbers or strings.
*/
external void ping(SendPort responsePort, {Object response,
int priority: IMMEDIATE});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698