Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3905)

Unified Diff: chrome/test/data/extensions/api_test/tabs/on_updated/test.js

Issue 2634333003: Convert SearchTabHelper to use the new navigation callbacks. (Closed)
Patch Set: closer to original Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/tabs/on_updated/test.js
diff --git a/chrome/test/data/extensions/api_test/tabs/on_updated/test.js b/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
index 41f2aa28c3100bc72ae1a4e0129b84a4b06431a7..16688a2f88835b6535412e4b9fa3f6bbaddcc6ce 100644
--- a/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
+++ b/chrome/test/data/extensions/api_test/tabs/on_updated/test.js
@@ -50,9 +50,18 @@ chrome.test.runTests([
function newTab() {
// Test for crbug.com/27208.
expect([
+ { title : "New Tab" },
{ status: 'loading', url: 'chrome://newtab/' },
{ status: 'complete' }
- ]);
+ ], function(info) {
+ // TODO(jam): remove this logic and the title line above when PlzNavigate
+ // is turned on by default. Right now the test has to handle both cases
+ // which have different timing. http://crbug.com/368813
+ if (info.status === 'loading' && capturedEventData.length == 0) {
+ expectedEventData.shift();
+ }
+ return false;
+ });
chrome.tabs.create({ url: 'chrome://newtab/' });
},
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698