Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 2634333003: Convert SearchTabHelper to use the new navigation callbacks. (Closed)
Patch Set: closer to original Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper_unittest.cc
diff --git a/chrome/browser/ui/search/search_tab_helper_unittest.cc b/chrome/browser/ui/search/search_tab_helper_unittest.cc
index 6c6cd0d74cde9b21a6fc5040b438314d2351b426..d460edda953a260d60292ca1245dc0418b419ed7 100644
--- a/chrome/browser/ui/search/search_tab_helper_unittest.cc
+++ b/chrome/browser/ui/search/search_tab_helper_unittest.cc
@@ -283,16 +283,13 @@ class TabTitleObserver : public content::WebContentsObserver {
base::string16 title_on_commit() { return title_on_commit_; }
private:
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* /* render_frame_host */,
- const GURL& /* validated_url */,
- bool /* is_error_page */) override {
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override {
title_on_start_ = web_contents()->GetTitle();
}
- void DidNavigateMainFrame(
- const content::LoadCommittedDetails& /* details */,
- const content::FrameNavigateParams& /* params */) override {
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override {
title_on_commit_ = web_contents()->GetTitle();
}
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | chrome/test/data/extensions/api_test/tabs/on_updated/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698