Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2634283003: [TypeFeedbackVector] DeclareGlobals needs a literals array (Closed)
Patch Set: Cleanup. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 VariableProxy* proxy = declaration->proxy(); 753 VariableProxy* proxy = declaration->proxy();
754 Variable* variable = proxy->var(); 754 Variable* variable = proxy->var();
755 DCHECK(!variable->binding_needs_init()); 755 DCHECK(!variable->binding_needs_init());
756 switch (variable->location()) { 756 switch (variable->location()) {
757 case VariableLocation::UNALLOCATED: { 757 case VariableLocation::UNALLOCATED: {
758 globals_->Add(variable->name(), zone()); 758 globals_->Add(variable->name(), zone());
759 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 759 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
760 DCHECK(!slot.IsInvalid()); 760 DCHECK(!slot.IsInvalid());
761 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 761 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
762 globals_->Add(isolate()->factory()->undefined_value(), zone()); 762 globals_->Add(isolate()->factory()->undefined_value(), zone());
763 globals_->Add(isolate()->factory()->undefined_value(), zone());
763 break; 764 break;
764 } 765 }
765 case VariableLocation::PARAMETER: 766 case VariableLocation::PARAMETER:
766 case VariableLocation::LOCAL: 767 case VariableLocation::LOCAL:
767 case VariableLocation::CONTEXT: 768 case VariableLocation::CONTEXT:
768 break; 769 break;
769 770
770 case VariableLocation::LOOKUP: 771 case VariableLocation::LOOKUP:
771 case VariableLocation::MODULE: 772 case VariableLocation::MODULE:
772 UNREACHABLE(); 773 UNREACHABLE();
773 } 774 }
774 } 775 }
775 776
776 777
777 void FullCodeGenerator::VisitFunctionDeclaration( 778 void FullCodeGenerator::VisitFunctionDeclaration(
778 FunctionDeclaration* declaration) { 779 FunctionDeclaration* declaration) {
779 VariableProxy* proxy = declaration->proxy(); 780 VariableProxy* proxy = declaration->proxy();
780 Variable* variable = proxy->var(); 781 Variable* variable = proxy->var();
781 switch (variable->location()) { 782 switch (variable->location()) {
782 case VariableLocation::UNALLOCATED: { 783 case VariableLocation::UNALLOCATED: {
783 globals_->Add(variable->name(), zone()); 784 globals_->Add(variable->name(), zone());
784 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 785 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
785 DCHECK(!slot.IsInvalid()); 786 DCHECK(!slot.IsInvalid());
786 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 787 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
788
789 // We need the slot where the literals array lives, too.
790 slot = declaration->fun()->LiteralFeedbackSlot();
791 DCHECK(!slot.IsInvalid());
792 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
793
787 Handle<SharedFunctionInfo> function = 794 Handle<SharedFunctionInfo> function =
788 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_); 795 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_);
789 // Check for stack-overflow exception. 796 // Check for stack-overflow exception.
790 if (function.is_null()) return SetStackOverflow(); 797 if (function.is_null()) return SetStackOverflow();
791 globals_->Add(function, zone()); 798 globals_->Add(function, zone());
792 break; 799 break;
793 } 800 }
794 801
795 case VariableLocation::PARAMETER: 802 case VariableLocation::PARAMETER:
796 case VariableLocation::LOCAL: { 803 case VariableLocation::LOCAL: {
(...skipping 1993 matching lines...) Expand 10 before | Expand all | Expand 10 after
2790 reinterpret_cast<uint32_t>( 2797 reinterpret_cast<uint32_t>(
2791 isolate->builtins()->OnStackReplacement()->entry())); 2798 isolate->builtins()->OnStackReplacement()->entry()));
2792 return ON_STACK_REPLACEMENT; 2799 return ON_STACK_REPLACEMENT;
2793 } 2800 }
2794 2801
2795 2802
2796 } // namespace internal 2803 } // namespace internal
2797 } // namespace v8 2804 } // namespace v8
2798 2805
2799 #endif // V8_TARGET_ARCH_MIPS 2806 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698