Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2634283003: [TypeFeedbackVector] DeclareGlobals needs a literals array (Closed)
Patch Set: Cleanup. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/compile-time-value.h" 7 #include "src/ast/compile-time-value.h"
8 #include "src/ast/scopes.h" 8 #include "src/ast/scopes.h"
9 #include "src/builtins/builtins-constructor.h" 9 #include "src/builtins/builtins-constructor.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 738 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 VariableProxy* proxy = declaration->proxy(); 749 VariableProxy* proxy = declaration->proxy();
750 Variable* variable = proxy->var(); 750 Variable* variable = proxy->var();
751 DCHECK(!variable->binding_needs_init()); 751 DCHECK(!variable->binding_needs_init());
752 switch (variable->location()) { 752 switch (variable->location()) {
753 case VariableLocation::UNALLOCATED: { 753 case VariableLocation::UNALLOCATED: {
754 globals_->Add(variable->name(), zone()); 754 globals_->Add(variable->name(), zone());
755 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 755 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
756 DCHECK(!slot.IsInvalid()); 756 DCHECK(!slot.IsInvalid());
757 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 757 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
758 globals_->Add(isolate()->factory()->undefined_value(), zone()); 758 globals_->Add(isolate()->factory()->undefined_value(), zone());
759 globals_->Add(isolate()->factory()->undefined_value(), zone());
759 break; 760 break;
760 } 761 }
761 case VariableLocation::PARAMETER: 762 case VariableLocation::PARAMETER:
762 case VariableLocation::LOCAL: 763 case VariableLocation::LOCAL:
763 case VariableLocation::CONTEXT: 764 case VariableLocation::CONTEXT:
764 break; 765 break;
765 766
766 case VariableLocation::LOOKUP: 767 case VariableLocation::LOOKUP:
767 case VariableLocation::MODULE: 768 case VariableLocation::MODULE:
768 UNREACHABLE(); 769 UNREACHABLE();
769 } 770 }
770 } 771 }
771 772
772 773
773 void FullCodeGenerator::VisitFunctionDeclaration( 774 void FullCodeGenerator::VisitFunctionDeclaration(
774 FunctionDeclaration* declaration) { 775 FunctionDeclaration* declaration) {
775 VariableProxy* proxy = declaration->proxy(); 776 VariableProxy* proxy = declaration->proxy();
776 Variable* variable = proxy->var(); 777 Variable* variable = proxy->var();
777 switch (variable->location()) { 778 switch (variable->location()) {
778 case VariableLocation::UNALLOCATED: { 779 case VariableLocation::UNALLOCATED: {
779 globals_->Add(variable->name(), zone()); 780 globals_->Add(variable->name(), zone());
780 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot(); 781 FeedbackVectorSlot slot = proxy->VariableFeedbackSlot();
781 DCHECK(!slot.IsInvalid()); 782 DCHECK(!slot.IsInvalid());
782 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone()); 783 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
784
785 // We need the slot where the literals array lives, too.
786 slot = declaration->fun()->LiteralFeedbackSlot();
787 DCHECK(!slot.IsInvalid());
788 globals_->Add(handle(Smi::FromInt(slot.ToInt()), isolate()), zone());
789
783 Handle<SharedFunctionInfo> function = 790 Handle<SharedFunctionInfo> function =
784 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_); 791 Compiler::GetSharedFunctionInfo(declaration->fun(), script(), info_);
785 // Check for stack overflow exception. 792 // Check for stack overflow exception.
786 if (function.is_null()) return SetStackOverflow(); 793 if (function.is_null()) return SetStackOverflow();
787 globals_->Add(function, zone()); 794 globals_->Add(function, zone());
788 break; 795 break;
789 } 796 }
790 797
791 case VariableLocation::PARAMETER: 798 case VariableLocation::PARAMETER:
792 case VariableLocation::LOCAL: { 799 case VariableLocation::LOCAL: {
(...skipping 2043 matching lines...) Expand 10 before | Expand all | Expand 10 after
2836 } 2843 }
2837 2844
2838 return INTERRUPT; 2845 return INTERRUPT;
2839 } 2846 }
2840 2847
2841 2848
2842 } // namespace internal 2849 } // namespace internal
2843 } // namespace v8 2850 } // namespace v8
2844 2851
2845 #endif // V8_TARGET_ARCH_ARM64 2852 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698