Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: components/arc/video_facing.h

Issue 2634263002: Pass camera facing info to audio client (Closed)
Patch Set: Pass VideoCaptureObserver as ctor parameter Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/video_facing.h
diff --git a/components/arc/video_facing.h b/components/arc/video_facing.h
new file mode 100644
index 0000000000000000000000000000000000000000..98222ffd870163a11f14446d50117263d788346d
--- /dev/null
+++ b/components/arc/video_facing.h
@@ -0,0 +1,27 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_ARC_VIDEO_FACING_H_
+#define COMPONENTS_ARC_VIDEO_FACING_H_
+
+namespace component {
+
+enum VideoFacingMode {
chfremer 2017/01/20 18:23:52 Can we make this an enum class?
shenghao 2017/01/24 12:52:00 Done.
+ NONE = 0,
chfremer 2017/01/20 18:23:52 Why is this entry needed and what does it mean?
shenghao 2017/01/24 12:52:00 This enum should have 1-1 mapping from VideoFacing
+ // Video device is facing the user. I.e. front camera.
+ USER,
+ // Video device is facing the environment. I.e. back camera.
+ ENVIRONMENT
+};
chfremer 2017/01/20 18:23:52 Thinking about convertible devices, could it happe
shenghao 2017/01/24 12:52:00 Yeah I am aware of the convertibles. However I sti
+
+class VideoCaptureObserver {
+ public:
+ virtual void OnVideoCaptureStarted(VideoFacingMode facing) = 0;
+ virtual void OnVideoCaptureStopped(VideoFacingMode facing) = 0;
+};
+
+}
+
+#endif // COMPONENTS_ARC_VIDEO_FACING_H_
+

Powered by Google App Engine
This is Rietveld 408576698