Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.h

Issue 2634263002: Pass camera facing info to audio client (Closed)
Patch Set: move DEPS Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.h
diff --git a/content/browser/renderer_host/media/media_stream_manager.h b/content/browser/renderer_host/media/media_stream_manager.h
index 8747539857459c586e05796386bea7f8223dc1c1..0ec39219da854e695c09612ca9bac9d7fe4df0c9 100644
--- a/content/browser/renderer_host/media/media_stream_manager.h
+++ b/content/browser/renderer_host/media/media_stream_manager.h
@@ -45,6 +45,7 @@
#include "content/common/media/media_devices.h"
#include "content/common/media/media_stream_options.h"
#include "content/public/browser/media_request_state.h"
+#include "media/base/video_facing.h"
namespace media {
class AudioManager;
@@ -97,6 +98,16 @@ class CONTENT_EXPORT MediaStreamManager
// Used to access MediaDevicesManager.
MediaDevicesManager* media_devices_manager();
+ // AddVideoCaptureObserver() and RemoveAllVideoCaptureObservers() should be
tommi (sloooow) - chröme 2017/02/14 09:11:19 nit: s/should/must
shenghao 2017/02/15 03:00:38 Done.
+ // called after InitializeDeviceManagersOnIOThread() and before
+ // WillDestroyCurrentMessageLoop(). They can be called more than once and it's
+ // ok to not call at all if the client is not interested in receiving
+ // media::VideoCaptureObserver callacks.
tommi (sloooow) - chröme 2017/02/14 09:11:19 callacks -> callbacks
shenghao 2017/02/15 03:00:38 Done.
+ // The methods can be called on whatever thread. The callbacks of
tommi (sloooow) - chröme 2017/02/14 09:11:19 I would much prefer to access the video_capture_ma
shenghao 2017/02/15 03:00:38 Done.
+ // media::VideoCaptureObserver arrive on BrowserThread::IO.
+ void AddVideoCaptureObserver(media::VideoCaptureObserver* capture_observer);
+ void RemoveAllVideoCaptureObservers();
+
// Creates a new media access request which is identified by a unique string
// that's returned to the caller. This will trigger the infobar and ask users
// for access to the device. |render_process_id| and |render_frame_id| are

Powered by Google App Engine
This is Rietveld 408576698