Add a policy to re-enable deprecated web platform features.

chrome/browser/policy/configuration_policy_handler_list_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
@@ skipping 16 matching lines @@
 #include "policy/policy_constants.h"
 
 #if !defined(OS_IOS)
 #include "chrome/browser/extensions/api/messaging/native_messaging_policy_handler.h"
 #include "chrome/browser/extensions/policy_handlers.h"
 #include "chrome/browser/net/disk_cache_dir_policy_handler.h"
 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h"
 #include "chrome/browser/policy/javascript_policy_handler.h"
 #include "chrome/browser/sessions/restore_on_startup_policy_handler.h"
 #include "chrome/browser/sync/sync_policy_handler.h"
+#include "content/public/common/renderer_preferences.h"
 #include "extensions/browser/pref_names.h"
 #include "extensions/common/manifest.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "ash/magnifier/magnifier_constants.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h"
 #include "chromeos/dbus/power_policy_controller.h"
@@ skipping 437 matching lines @@
 #if !defined(OS_IOS)
 // Mapping from extension type names to Manifest::Type.
 StringToIntEnumListPolicyHandler::MappingEntry kExtensionAllowedTypesMap[] = {
   { "extension", extensions::Manifest::TYPE_EXTENSION },
   { "theme", extensions::Manifest::TYPE_THEME },
   { "user_script", extensions::Manifest::TYPE_USER_SCRIPT },
   { "hosted_app", extensions::Manifest::TYPE_HOSTED_APP },
   { "legacy_packaged_app", extensions::Manifest::TYPE_LEGACY_PACKAGED_APP },
   { "platform_app", extensions::Manifest::TYPE_PLATFORM_APP },
 };
+
+// Maps feature tags as specified in policy to the corresponding enum value.
+StringToIntEnumListPolicyHandler::MappingEntry

[Andrew T Wilson (Slow), 2014/05/08 11:32:45]

BTW, should add a TODO + a crbug entry to remove this once the deprecation date
is passed.

[Mattias Nissler (ping if slow), 2014/05/09 16:38:27]

Adam, would you like to track this as part of http://crbug.com/345831 or would
you prefer a separate bug?

+    kEnableDeprecatedWebPlatformFeaturesMap[] = {
+  {"ShowModalDialog",

[Mattias Nissler (ping if slow), 2014/05/06 14:31:15]

We should talk some more about the naming - do we want to explicitly include the
intended removal date into the tag name?

We could as well put a hard time limit here, and we'd automatically stop
supporting the feature once we're past that time. That would have the benefit of
avoiding the negative effect of people staying on old versions just because
those still support the deprecation policy - the feature would self destruct at
a prescribed point in time. WDYT?

[Andrew T Wilson (Slow), 2014/05/08 11:32:45]

If people are going to stay on old versions to keep deprecated features, then
they'll just stick to a version that is pre-deprecation.

That said, I like the idea of hardcoding a deprecation date, so I'm OK with
doing that.

Also, I think we should absolutely come up with some standard for naming that
includes the final deprecation date - I'd suggest "XXXXUntilDate" (for example:
"ShowModalDialogUntilDec2014").

[Mattias Nissler (ping if slow), 2014/05/09 16:38:27]

That's certainly a risk, but they'd have to retain an old copy of the installer
and wipe Chrome state for all users etc., so that's pretty painful...

In the end, we need to decide which option we think is less risky overall. I
tend to lean towards timed self-destruct. What do others think?
Okay, how about <FEATURE>_Until_<yyyymmdd>? If we do self-destruct, we should
specify the day IMHO.

+   content::RENDERER_PREFERENCES_DEPRECATED_FEATURE_SHOW_MODAL_DIALOG},
+};
 #endif  // !defined(OS_IOS)
 
 }  // namespace
 
 void PopulatePolicyHandlerParameters(PolicyHandlerParameters* parameters) {
 #if defined(OS_CHROMEOS)
   if (chromeos::UserManager::IsInitialized()) {
     const chromeos::User* user = chromeos::UserManager::Get()->GetActiveUser();
     if (user)
       parameters->user_id_hash = user->username_hash();
@@ skipping 50 matching lines @@
   handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
       new extensions::ExtensionURLPatternListPolicyHandler(
           key::kExtensionInstallSources,
           extensions::pref_names::kAllowedInstallSites)));
   handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
       new StringToIntEnumListPolicyHandler(
           key::kExtensionAllowedTypes,
           extensions::pref_names::kAllowedTypes,
           kExtensionAllowedTypesMap,
           kExtensionAllowedTypesMap + arraysize(kExtensionAllowedTypesMap))));
+  handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
+      new StringToIntEnumListPolicyHandler(
+          key::kEnableDeprecatedWebPlatformFeatures,
+          prefs::kEnableDeprecatedWebPlatformFeatures,
+          kEnableDeprecatedWebPlatformFeaturesMap,
+          kEnableDeprecatedWebPlatformFeaturesMap +
+              arraysize(kEnableDeprecatedWebPlatformFeaturesMap))));
 #endif  // !defined(OS_IOS)
 
 #if !defined(OS_CHROMEOS) && !defined(OS_ANDROID) && !defined(OS_IOS)
   handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
       new DiskCacheDirPolicyHandler()));
 
   handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
       new extensions::NativeMessagingHostListPolicyHandler(
           key::kNativeMessagingWhitelist,
           extensions::pref_names::kNativeMessagingWhitelist,
@@ skipping 159 matching lines @@
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(OS_ANDROID) || defined(OS_IOS)
   handlers->AddHandler(make_scoped_ptr<ConfigurationPolicyHandler>(
       new ManagedBookmarksPolicyHandler()));
 #endif
   return handlers.Pass();
 }
 
 }  // namespace policy