[Media Router] Add integration browser tests

chrome/test/media_router/media_router_integration_browsertest.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_
 #define CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 56 matching lines @@
   // |web_contents|: The web contents of the test page which invokes the popup
   //                 dialog.
   content::WebContents* GetMRDialog(content::WebContents* web_contents);
 
   // Checks that the chrome modal dialog does not exist.
   bool IsDialogClosed(content::WebContents* web_contents);
   void WaitUntilDialogClosed(content::WebContents* web_contents);
 
   void CheckDialogRemainsOpen(content::WebContents* web_contents);
 
-  void OpenTestPage(base::FilePath::StringPieceType file);
-  void OpenTestPageInNewTab(base::FilePath::StringPieceType file);
+  // Opens "basic_test.html," waits for sinks to be available, and starts a
+  // session in |browser|.
+  void StartSessionWithTestPage(Browser* browser);

[mark a. foltz, 2017/01/20 19:00:09]

Here's a thought.  We could run all the test cases with a normal profile and an
incognito profile.

Would it be possible to create two subclasses of a shared test class that
defines the tests? Each subclass would set browser() differently and run the
same list of test cases.

I looked through the googletest documentation and didn't see a quick way to run
the same tests twice with two different test classes, other than manually
defining two lists of test cases that each invoke a test method declared in the
base class.  Maybe there's a macro solution?

[takumif, 2017/02/07 22:17:35]

I made a subclass of MediaRouterIntegrationBrowserTest for incognito. I wonder
if there is a cleaner way to do this. I haven't made the incognito class to run
all the tests since many of the tests were failing for various reasons.

+
+  // Opens "basic_test.html," waits for sinks to be available, starts a session,
+  // and chooses a sink with the name |kTestSinkName| in |browser|.
+  void StartSessionWithTestPageAndChooseSink(Browser* browser);
+
+  void OpenTestPage(base::FilePath::StringPieceType file, Browser* browser);
+  void OpenTestPageInNewTab(base::FilePath::StringPieceType file,
+                            Browser* browser);
 
   void SetTestData(base::FilePath::StringPieceType test_data_file);
 
   // Start session and wait until the pop dialog shows up.
   // |web_contents|: The web contents of the test page which invokes the popup
   //                 dialog.
   void StartSession(content::WebContents* web_contents);
 
   // Open the chrome modal dialog.
   // |web_contents|: The web contents of the test page which invokes the popup
   //                 dialog.
   content::WebContents* OpenMRDialog(content::WebContents* web_contents);
 
   bool IsRouteCreatedOnUI();
 
   bool IsRouteClosedOnUI();
 
-  bool IsSinkDiscoveredOnUI();
+  bool IsSinkDiscoveredOnUI(content::WebContents* web_contents);
 
   // Close route through clicking 'Stop casting' button in route details dialog.
   void CloseRouteOnUI();
 
   // Wait for the route to show up in the UI with a timeout. Fails if the
   // route did not show up before the timeout.
   void WaitUntilRouteCreated();
 
   // Wait until there is an issue showing in the UI.
   void WaitUntilIssue();
 
   // Returns true if there is an issue showing in the UI.
   bool IsUIShowingIssue();
 
   // Returns the title of issue showing in UI. It is an error to call this if
   // there are no issues showing in UI.
   std::string GetIssueTitle();
 
   // Returns the route ID for the specific sink.
   std::string GetRouteId(const std::string& sink_id);
 
-  // Wait for the specific sink shows up in UI with a timeout. Fails if the sink
-  // doesn't show up before the timeout.
-  void WaitUntilSinkDiscoveredOnUI();
+  // Waits for the specific sink shows up in a media router dialog shown for
+  // |web_contents| with a timeout. Fails if the sink doesn't show up before the
+  // timeout.
+  void WaitUntilSinkDiscoveredOnUI(content::WebContents* web_contents);
 
   // Checks if media router dialog is fully loaded.
   bool IsDialogLoaded(content::WebContents* dialog_contents);
 
   // Wait until media router dialog is fully loaded.
   void WaitUntilDialogFullyLoaded(content::WebContents* dialog_contents);
 
+  // Checks that the session started for |web_contents| has connected and is the
+  // default session.
+  void CheckSessionValidity(content::WebContents* web_contents);
+
+  void RunBasicTest(Browser* browser);
+
+  void RunReconnectSessionTest(Browser* browser);
+
   std::string receiver() const { return receiver_; }
 
  private:
   // Get the full path of the resource file.
   // |relative_path|: The relative path to
   //                  <chromium src>/out/<build config>/media_router/
   //                  browser_test_resources/
   base::FilePath GetResourceFile(
       base::FilePath::StringPieceType relative_path) const;
 
   std::unique_ptr<content::TestNavigationObserver> test_navigation_observer_;
 
   // Fields
   std::string receiver_;
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_