[Media Router] Add integration browser tests

chrome/test/media_router/media_router_integration_browsertest.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_
 #define CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 56 matching lines @@
   // |web_contents|: The web contents of the test page which invokes the popup
   //                 dialog.
   content::WebContents* GetMRDialog(content::WebContents* web_contents);
 
   // Checks that the chrome modal dialog does not exist.
   bool IsDialogClosed(content::WebContents* web_contents);
   void WaitUntilDialogClosed(content::WebContents* web_contents);
 
   void CheckDialogRemainsOpen(content::WebContents* web_contents);
 
+  // Opens "basic_test.html," waits for sinks to be available if |wait_for_sink|
+  // is true, and starts a session.
+  content::WebContents* StartSessionWithTestPage(bool wait_for_sink);

[mark a. foltz, 2017/02/09 23:29:59]

Slight preference for having explicit functions StartSessionWithTestPageNow()
and StartSessionWithTestPageAndSink()

If it doesn't result in excessive code duplication in the implementation.

[takumif, 2017/02/14 19:11:48]

It does result in a bit of code duplication, but the more descriptive method
names are probably better.

+
+  // Opens "basic_test.html," waits for sinks to be available, starts a session,
+  // and chooses a sink with the name |kTestSinkName|. Also checks that the
+  // session has successfully started if |should_succeed| is true.
+  content::WebContents* StartSessionWithTestPageAndChooseSink(

[mark a. foltz, 2017/02/09 23:29:59]

Maybe the caller could choose to call CheckSessionValidity() instead of passing
a should_succeed parameter here?  Or are they checking different things?

[takumif, 2017/02/14 19:11:48]

Done.

+      bool should_succeed);
+
   void OpenTestPage(base::FilePath::StringPieceType file);
   void OpenTestPageInNewTab(base::FilePath::StringPieceType file);
 
   void SetTestData(base::FilePath::StringPieceType test_data_file);
 
   // Start session and wait until the pop dialog shows up.
   // |web_contents|: The web contents of the test page which invokes the popup
   //                 dialog.
   void StartSession(content::WebContents* web_contents);
 
@@ skipping 31 matching lines @@
   // Wait for the specific sink shows up in UI with a timeout. Fails if the sink
   // doesn't show up before the timeout.
   void WaitUntilSinkDiscoveredOnUI();
 
   // Checks if media router dialog is fully loaded.
   bool IsDialogLoaded(content::WebContents* dialog_contents);
 
   // Wait until media router dialog is fully loaded.
   void WaitUntilDialogFullyLoaded(content::WebContents* dialog_contents);
 
+  // Checks that the session started for |web_contents| has connected and is the
+  // default session.
+  void CheckSessionValidity(content::WebContents* web_contents);
+
+  // Hides the dialog shown for |web_contents| after waiting for a sink to
+  // appear if |wait_for_sink| is true, or immediately if false.
+  void HideMediaRouterDialog(content::WebContents* web_contents,

[mark a. foltz, 2017/02/09 23:29:59]

HideMediaRouterDialogNow() and HideMediaRouterDialogWithSink() vs. wait_for_sink

[takumif, 2017/02/14 19:11:48]

Factored out the common part into GetControllerForShownDialog() and got rid of
HideMediaRouterDialog().

+                             bool wait_for_sink);
+
+  // Returns the active WebContents for the current window.
+  content::WebContents* GetActiveWebContents();
+
+  // Runs a basic test in which a session is created through the MediaRouter
+  // dialog, then terminated.
+  void RunBasicTest();
+
+  // Runs a test in which we start a session and reconnect to it from another
+  // tab.
+  void RunReconnectSessionTest();
+
   std::string receiver() const { return receiver_; }
 
  private:
   // Get the full path of the resource file.
   // |relative_path|: The relative path to
   //                  <chromium src>/out/<build config>/media_router/
   //                  browser_test_resources/
   base::FilePath GetResourceFile(
       base::FilePath::StringPieceType relative_path) const;
 
   std::unique_ptr<content::TestNavigationObserver> test_navigation_observer_;
 
   // Fields
   std::string receiver_;
 };
 
+class MediaRouterIntegrationIncognitoBrowserTest
+    : public MediaRouterIntegrationBrowserTest {
+ public:
+  void InstallAndEnableMRExtension() override;
+  void UninstallMRExtension() override;
+  Browser* browser() override;
+
+ private:
+  Browser* browser_ = nullptr;

[mark a. foltz, 2017/02/09 23:29:59]

Does this hide a member in the superclass?  Maybe name it incognito_browser_ to
avoid any name collisions.

[takumif, 2017/02/14 19:11:48]

Done. Also renaming extension_id_ to incognito_extension_id_.

+  std::string extension_id_;
+};
+
 }  // namespace media_router
 
 #endif  // CHROME_TEST_MEDIA_ROUTER_MEDIA_ROUTER_INTEGRATION_BROWSERTEST_H_