[Media Router] Add integration browser tests

chrome/test/media_router/media_router_base_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/media_router/media_router_base_browsertest.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/path_service.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/timer/elapsed_timer.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/common/switches.h"
 
 
 namespace {
-// Command line argument to specify CRX extension location.
-const char kExtensionCrx[] = "extension-crx";
 // Command line argument to specify unpacked extension location.
 const char kExtensionUnpacked[] = "extension-unpacked";
 }  // namespace
 
 
 namespace media_router {
 
 MediaRouterBaseBrowserTest::MediaRouterBaseBrowserTest()
     : extension_load_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
                             base::WaitableEvent::InitialState::NOT_SIGNALED),
       extension_host_created_(false) {
 }
 
 MediaRouterBaseBrowserTest::~MediaRouterBaseBrowserTest() {
 }
 
 void MediaRouterBaseBrowserTest::SetUp() {
   ParseCommandLine();
   ExtensionBrowserTest::SetUp();
 }
 
 void MediaRouterBaseBrowserTest::TearDown() {
   ExtensionBrowserTest::TearDown();
 }
 
 void MediaRouterBaseBrowserTest::SetUpOnMainThread() {
   ExtensionBrowserTest::SetUpOnMainThread();
-  extensions::ProcessManager* process_manager =
-      extensions::ProcessManager::Get(browser()->profile());
+  extensions::ProcessManager* process_manager = extensions::ProcessManager::Get(
+      browser()->profile()->GetOriginalProfile());
   DCHECK(process_manager);
   process_manager->AddObserver(this);
   InstallAndEnableMRExtension();
   extension_load_event_.Wait();
 }
 
 void MediaRouterBaseBrowserTest::TearDownOnMainThread() {
   UninstallMRExtension();
   extensions::ProcessManager* process_manager =
       extensions::ProcessManager::Get(browser()->profile());
   DCHECK(process_manager);
   process_manager->RemoveObserver(this);
   ExtensionBrowserTest::TearDownOnMainThread();
 }
 
 void MediaRouterBaseBrowserTest::InstallAndEnableMRExtension() {
-  if (is_unpacked()) {
-    const extensions::Extension* extension = LoadExtension(extension_unpacked_);
-    extension_id_ = extension->id();
-  } else {
-    NOTIMPLEMENTED();
-  }
+  const extensions::Extension* extension = LoadExtension(extension_unpacked_);
+  extension_id_ = extension->id();
 }
 
 void MediaRouterBaseBrowserTest::UninstallMRExtension() {
   if (!extension_id_.empty()) {
     UninstallExtension(extension_id_);
   }
 }
 
 bool MediaRouterBaseBrowserTest::ConditionalWait(
     base::TimeDelta timeout,
@@ skipping 23 matching lines @@
 void MediaRouterBaseBrowserTest::OnBackgroundHostCreated(
     extensions::ExtensionHost* host) {
   extension_host_created_ = true;
   DVLOG(0) << "Host created";
   extension_load_event_.Signal();
 }
 
 void MediaRouterBaseBrowserTest::ParseCommandLine() {
   DVLOG(0) << "ParseCommandLine";
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-
-  extension_crx_ = command_line->GetSwitchValuePath(kExtensionCrx);
   extension_unpacked_ = command_line->GetSwitchValuePath(kExtensionUnpacked);
 
   // Check if there is mr_extension folder under PRODUCT_DIR folder.
-  if (extension_crx_.empty() && extension_unpacked_.empty()) {
+  if (extension_unpacked_.empty()) {
     base::FilePath base_dir;
     ASSERT_TRUE(PathService::Get(base::DIR_MODULE, &base_dir));
     base::FilePath extension_path =
         base_dir.Append(FILE_PATH_LITERAL("mr_extension/"));
     if (PathExists(extension_path)) {
       extension_unpacked_ = extension_path;
     }
   }
 
-  // Exactly one of these two arguments should be provided.
-  ASSERT_NE(extension_crx_.empty(), extension_unpacked_.empty());
+  // An unpacked component extension must be provided.
+  ASSERT_FALSE(extension_unpacked_.empty());
+}
+
+Browser* MediaRouterBaseBrowserTest::browser() {
+  return ExtensionBrowserTest::browser();

[mark a. foltz, 2017/02/09 23:29:58]

If this method returns a Browser*, there's no need to override it from the
superclass.

[takumif, 2017/02/14 19:11:48]

The superclass' browser() is not virtual, and if I want to make
MediaRouterBaseBrowserTest::browser() virtual so that it can be overridden by
the incognito class, I need to define it here like this. Maybe there is a better
way to do this?

[mark a. foltz, 2017/02/15 00:41:27]

It's a little weird to override a non-virtual method with a virtual one.  But I
guess it's legal, and the style guide doesn't prohibit it, so I guess it's okay.
 Please add a note explaining why you're doing this.

[takumif, 2017/02/18 20:44:05]

Done.

 }
 
 }  // namespace media_router