Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: test/cctest/test-parsing.cc

Issue 2634123002: [parser] Pessimistically assume top-level variables will be assigned. (Closed)
Patch Set: Feedback. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/parsing/pattern-rewriter.cc ('K') | « src/parsing/pattern-rewriter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index a3ee6bea045ad4c9a788922a1ed833f44b9c291e..2fb38faa02fe662c344823e92e8d2692ae7334b2 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -3505,6 +3505,66 @@ TEST(MaybeAssignedParameters) {
}
}
+TEST(MaybeAssignedTopLevel) {
+ i::Isolate* isolate = CcTest::i_isolate();
+ i::HandleScope scope(isolate);
+ LocalContext env;
+ i::Factory* factory = isolate->factory();
+
+ const char* prefixes[] = {
+ "let foo; ", "let foo = 0; ",
+ "let [foo] = [1]; ", "let {foo} = {foo: 2}; ",
+ "let {foo=3} = {}; ",
+ };
+ const char* sources[] = {
+ "function bar() {foo = 42}; ext(bar); ext(foo)",
+ "ext(function() {foo++}); ext(foo)",
+ "bar = () => --foo; ext(bar); ext(foo)",
+ "function* bar() {eval(ext)}; ext(bar); ext(foo)",
+ };
+
+ for (unsigned i = 0; i < arraysize(prefixes); ++i) {
+ const char* prefix = prefixes[i];
+ for (unsigned j = 0; j < arraysize(sources); ++j) {
+ const char* source = sources[j];
+ i::ScopedVector<char> program(Utf8LengthHelper(prefix) +
+ Utf8LengthHelper(source) + 1);
+ i::SNPrintF(program, "%s%s", prefix, source);
+ i::Zone zone(isolate->allocator(), ZONE_NAME);
+
+ i::Handle<i::String> string =
+ factory->InternalizeUtf8String(program.start());
+ string->PrintOn(stdout);
+ printf("\n");
+ i::Handle<i::Script> script = factory->NewScript(string);
+
+ for (unsigned allow_lazy = 0; allow_lazy < 2; ++allow_lazy) {
+ for (unsigned module = 0; module < 2; ++module) {
+ std::unique_ptr<i::ParseInfo> info;
+ info = std::unique_ptr<i::ParseInfo>(new i::ParseInfo(&zone, script));
+ info->set_module(module);
+ info->set_allow_lazy_parsing(allow_lazy);
+
+ CHECK(i::parsing::ParseProgram(info.get()));
+ CHECK(i::Compiler::Analyze(info.get()));
+
+ CHECK_NOT_NULL(info->literal());
+ i::Scope* scope = info->literal()->scope();
+ CHECK(!scope->AsDeclarationScope()->was_lazily_parsed());
+ CHECK_NULL(scope->sibling());
+ CHECK(module ? scope->is_module_scope() : scope->is_script_scope());
+
+ const i::AstRawString* var_name =
+ info->ast_value_factory()->GetOneByteString("foo");
+ i::Variable* var = scope->Lookup(var_name);
+ CHECK(var->is_used());
+ CHECK(var->maybe_assigned() == i::kMaybeAssigned);
+ }
+ }
+ }
+ }
+}
+
namespace {
i::Scope* DeserializeFunctionScope(i::Isolate* isolate, i::Zone* zone,
« src/parsing/pattern-rewriter.cc ('K') | « src/parsing/pattern-rewriter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698