Replace OnceOffCreateShortcuts with UpdateShortcutsForAllAppsIfNeeded.

chrome/browser/apps/shortcut_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/shortcut_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
@@ skipping 13 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/one_shot_event.h"
 
 using extensions::Extension;
 
 namespace {
 
+// This version number is stored in local prefs to check whether app shortcuts
+// need to be recreated. This might happen when we change various aspects of app
+// shortcuts like command-line flags or associated icons, binaries, etc.
+const int kCurrentAppShortcutsVersion = 1;

[tapted, 2014/05/30 06:33:27]

Note we might want this to be per-platform. And the first time windows/linux
gets implemented we will of course need to increment it on those platforms to 2.
I guess we can worry about it later (#ifdef or extern const int or similar). Or
we could set it to 0 on win/linux initially.

[jackhou1, 2014/06/02 04:25:19]

 Yeah, I think ifdefs here is fine. Similar to kDesiredSizes in web_app.cc. I
also realised this should start at 0, and we should only increment when we want
to trigger an update. (There's nothing to update in this CL).

+
 // Creates a shortcut for an application in the applications menu, if there is
 // not already one present.
 void CreateShortcutsInApplicationsMenu(Profile* profile,
                                        const Extension* app) {
   web_app::ShortcutLocations creation_locations;
   // Create the shortcut in the Chrome Apps subdir.
   creation_locations.applications_menu_location =
       web_app::APP_MENU_LOCATION_SUBDIR_CHROMEAPPS;
   web_app::CreateShortcuts(
       web_app::SHORTCUT_CREATION_AUTOMATED, creation_locations, profile, app);
 }
 
-bool ShouldCreateShortcutFor(Profile* profile, const Extension* extension) {
-  return extension->is_platform_app() &&
-      extension->location() != extensions::Manifest::COMPONENT &&
-      extensions::ui_util::ShouldDisplayInAppLauncher(extension, profile);
-}
-
 }  // namespace
 
 // static
 void AppShortcutManager::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   // Indicates whether app shortcuts have been created.
-  registry->RegisterBooleanPref(
-      prefs::kAppShortcutsHaveBeenCreated, false,
+  registry->RegisterIntegerPref(
+      prefs::kAppShortcutsVersion, 0,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
 }
 
 AppShortcutManager::AppShortcutManager(Profile* profile)
     : profile_(profile),
       is_profile_info_cache_observer_(false),
       prefs_(profile->GetPrefs()),
       extension_registry_observer_(this),
       weak_ptr_factory_(this) {
   // Use of g_browser_process requires that we are either on the UI thread, or
   // there are no threads initialized (such as in unit tests).
   DCHECK(!content::BrowserThread::IsThreadInitialized(
              content::BrowserThread::UI) ||
          content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   extension_registry_observer_.Add(
       extensions::ExtensionRegistry::Get(profile_));
-  // Wait for extensions to be ready before running OnceOffCreateShortcuts.
+  // Wait for extensions to be ready before running
+  // UpdateShortcutsForAllAppsIfNeeded.
   extensions::ExtensionSystem::Get(profile)->ready().Post(
       FROM_HERE,
-      base::Bind(&AppShortcutManager::OnceOffCreateShortcuts,
+      base::Bind(&AppShortcutManager::UpdateShortcutsForAllAppsIfNeeded,
                  weak_ptr_factory_.GetWeakPtr()));
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   // profile_manager might be NULL in testing environments.
   if (profile_manager) {
     profile_manager->GetProfileInfoCache().AddObserver(this);
     is_profile_info_cache_observer_ = true;
   }
 }
 
@@ skipping 14 matching lines @@
     const std::string& old_name) {
   if (!extension->is_app())
     return;
 
   // If the app is being updated, update any existing shortcuts but do not
   // create new ones. If it is being installed, automatically create a
   // shortcut in the applications menu (e.g., Start Menu).
   if (is_update && !from_ephemeral) {
     web_app::UpdateAllShortcuts(
         base::UTF8ToUTF16(old_name), profile_, extension);
-  } else if (ShouldCreateShortcutFor(profile_, extension)) {
+  } else {
     CreateShortcutsInApplicationsMenu(profile_, extension);
   }
 }
 
 void AppShortcutManager::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const Extension* extension) {
   web_app::DeleteAllShortcuts(profile_, extension);
 }
 
 void AppShortcutManager::OnProfileWillBeRemoved(
     const base::FilePath& profile_path) {
   if (profile_path != profile_->GetPath())
     return;
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&web_app::internals::DeleteAllShortcutsForProfile,
                  profile_path));
 }
 
-void AppShortcutManager::OnceOffCreateShortcuts() {
-  if (prefs_->GetBoolean(prefs::kAppShortcutsHaveBeenCreated))
+void AppShortcutManager::UpdateShortcutsForAllAppsIfNeeded() {
+  int last_version = prefs_->GetInteger(prefs::kAppShortcutsVersion);
+  if (last_version >= kCurrentAppShortcutsVersion)
     return;
 
-  prefs_->SetBoolean(prefs::kAppShortcutsHaveBeenCreated, true);
-
-  // Check if extension system/service are available. They might not be in
-  // tests.
-  extensions::ExtensionSystem* extension_system;
-  ExtensionServiceInterface* extension_service;
-  if (!(extension_system = extensions::ExtensionSystem::Get(profile_)) ||
-      !(extension_service = extension_system->extension_service()))
-    return;
-
-  // Create an applications menu shortcut for each app in this profile.
-  const extensions::ExtensionSet* apps = extension_service->extensions();
-  for (extensions::ExtensionSet::const_iterator it = apps->begin();
-       it != apps->end(); ++it) {
-    if (ShouldCreateShortcutFor(profile_, it->get()))
-      CreateShortcutsInApplicationsMenu(profile_, it->get());
-  }
+  web_app::UpdateShortcutsForAllApps(profile_);
+  prefs_->SetInteger(prefs::kAppShortcutsVersion, kCurrentAppShortcutsVersion);
 }