Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 263393002: Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from c/b/e/api (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED from image_writer_private and signed_in_devices API. Use ExtensionRegistryObserver instead. R=kalman@chromium.org BUG=354458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269648

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address review #

Patch Set 3 : fix test #

Messages

Total messages: 12 (0 generated)
limasdf
PTAL
6 years, 7 months ago (2014-05-06 14:24:23 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/263393002/diff/100001/chrome/browser/extensions/api/image_writer_private/operation_manager.cc File chrome/browser/extensions/api/image_writer_private/operation_manager.cc (right): https://codereview.chromium.org/263393002/diff/100001/chrome/browser/extensions/api/image_writer_private/operation_manager.cc#newcode228 chrome/browser/extensions/api/image_writer_private/operation_manager.cc:228: } this case looks wrong to me, it ...
6 years, 7 months ago (2014-05-06 15:04:10 UTC) #2
limasdf
Thanks for the review. Removed chrome::NOTIFICATION_EXTENSION_UNINSTALLED. and codes for that. https://codereview.chromium.org/263393002/diff/100001/chrome/browser/extensions/api/image_writer_private/operation_manager.cc File chrome/browser/extensions/api/image_writer_private/operation_manager.cc (right): https://codereview.chromium.org/263393002/diff/100001/chrome/browser/extensions/api/image_writer_private/operation_manager.cc#newcode228 ...
6 years, 7 months ago (2014-05-06 15:19:10 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-06 15:29:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/263393002/120001
6 years, 7 months ago (2014-05-06 15:30:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-06 21:05:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 05:11:45 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 06:04:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-07 06:04:45 UTC) #9
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-10 22:31:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/263393002/160001
6 years, 7 months ago (2014-05-10 22:32:20 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:26:53 UTC) #12
Message was sent while issue was closed.
Change committed as 269648

Powered by Google App Engine
This is Rietveld 408576698