[inspector] implemented blackboxing inside v8

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index eb4b343350dc2c06de4853713eb99e7929c5f7c2..0f97ae03a509c889fd89b0063da53eabab0b3a44 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -13448,6 +13448,16 @@ String* SharedFunctionInfo::DebugName() {
   return String::cast(n);
 }
 
+bool SharedFunctionInfo::DebugIsBlackboxed() {
+  if (!computed_debug_is_blackboxed()) {
+    HandleScope handle_scope(GetIsolate());
+    Handle<SharedFunctionInfo> info(this);
+    set_debug_is_blackboxed(info->GetIsolate()->debug()->IsBlackboxed(info));
+    set_computed_debug_is_blackboxed(true);

[Yang, 2017/01/23 08:48:29]

Oh yeah, this is not GC-safe. set_debug_is_blackboxed refers to 'this'. however,
since debug()->IsBlackboxed() can trigger GC, 'this' can become invalid if GC
moves the shared function info.

Can you make this method static with this signature?
static bool SharedFunctionInfo::DebugIsBlackboxed(Handle<SharedFunctionInfo>)

Then again, if we did that, why not just call Debug::IsBlackboxed from where we
need it and only store the bits on the shared function info?

[kozy, 2017/01/23 20:28:01]

Thank you! Done. I'll try to be more accurate about possible gc next time.

+  }
+  return debug_is_blackboxed();
+}
+
 bool SharedFunctionInfo::HasNoSideEffect() {
   if (!computed_has_no_side_effect()) {
     DisallowHeapAllocation not_handlified;