Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: src/debug/debug-interface.h

Issue 2633803002: [inspector] implemented blackboxing inside v8 (Closed)
Patch Set: one more test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-interface.h
diff --git a/src/debug/debug-interface.h b/src/debug/debug-interface.h
index 127ce66caf6247a1090506197048a14c46c78227..5edea5be597f02c96d9c59249d770a3b81fbca2f 100644
--- a/src/debug/debug-interface.h
+++ b/src/debug/debug-interface.h
@@ -86,13 +86,11 @@ void ChangeBreakOnException(Isolate* isolate, ExceptionBreakState state);
enum StepAction {
StepOut = 0, // Step out of the current function.
StepNext = 1, // Step to the next statement in the current function.
- StepIn = 2, // Step into new functions invoked or the next statement
+ StepIn = 2 // Step into new functions invoked or the next statement
// in the current function.
- StepFrame = 3 // Step into a new frame or return to previous frame.
};
void PrepareStep(Isolate* isolate, StepAction action);
-void ClearStepping(Isolate* isolate);
/**
* Out-of-memory callback function.
@@ -126,6 +124,7 @@ class Script {
bool GetPossibleBreakpoints(const debug::Location& start,
const debug::Location& end,
std::vector<debug::Location>* locations) const;
+ void BlackboxStateChanged() const;
dgozman 2017/01/19 21:49:14 Does it make sense to push ranges here instead of
dgozman 2017/01/19 22:34:20 - ResetBlackboxedStateCache - Make it a separate f
kozy 2017/01/20 02:32:36 Done.
kozy 2017/01/20 02:32:36 Acknowledged.
private:
int GetSourcePosition(const debug::Location& location) const;
@@ -165,6 +164,15 @@ class DebugEventListener {
void SetDebugEventListener(Isolate* isolate, DebugEventListener* listener);
+typedef std::function<bool(v8::Local<debug::Script> script,
+ const debug::Location& start,
+ const debug::Location& end, void* data)>
+ IsBlackboxedCallback;
+void SetIsBlackboxedCallback(Isolate* isolate, IsBlackboxedCallback callback,
dgozman 2017/01/19 21:49:14 Make this a part of DebugEventListener?
kozy 2017/01/20 02:32:37 DebugEventListener -> DebugDelegate and done.
+ void* data);
+
+bool HasUserFrameOnStack(Isolate* isolate);
dgozman 2017/01/19 21:49:14 - Let's move this closer to other functions (e.g.n
kozy 2017/01/20 02:32:37 Done.
+
} // namespace debug
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698