[inspector] implemented blackboxing inside v8

src/compiler.cc

Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 6f123ea2b3e6ad5db98cd7ac1d048fed70ab0e6a..4c1c539ba7373782786c04523131a8bf4468cf76 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -505,6 +505,7 @@ bool CompileUnoptimizedInnerFunctionsRecursively(
       shared =
           isolate->factory()->NewSharedFunctionInfoForLiteral(literal, script);
       shared->set_is_toplevel(false);
+      isolate->debug()->OnNewSharedFunctionInfo(shared);
     }
 
     Zone zone(isolate->allocator(), ZONE_NAME);
@@ -1087,6 +1088,7 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
     DCHECK_EQ(kNoSourcePosition, lit->function_token_position());
     result = isolate->factory()->NewSharedFunctionInfoForLiteral(lit, script);
     result->set_is_toplevel(true);
+    isolate->debug()->OnNewSharedFunctionInfo(result);

[Yang, 2017/01/19 13:55:35]

I wonder whether it is easier to keep track of all the locations, or lazily
compute it, and cache it on the shared function info. We would need two bits on
the shared function info, one to cache, and one to state whether the cache is
up-to-date.

The advantage is that you would not have to keep track of all the places we add
new shared function info, and would not need to eagerly compute the blackboxing
state. We do the same thing for side-effect-free debug evaluate. See
SharedFunctionInfo::HasNoSideEffect.

When you reset the black box state, you would simply need to iterate all shared
function infos and reset the first bit. That's probably a lot less expensive
than computing the black box state for all of them at once.

[kozy, 2017/01/19 16:08:38]

Done.

     parse_info->set_shared_info(result);
     parse_info->set_function_literal_id(result->function_literal_id());
 
@@ -1667,6 +1669,7 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
   Handle<SharedFunctionInfo> result =
       isolate->factory()->NewSharedFunctionInfoForLiteral(literal, script);
   result->set_is_toplevel(false);
+  isolate->debug()->OnNewSharedFunctionInfo(result);
   Scope* outer_scope = literal->scope()->GetOuterScopeWithContext();
   if (outer_scope) {
     result->set_outer_scope_info(*outer_scope->scope_info());