Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/objects-inl.h

Issue 2633803002: [inspector] implemented blackboxing inside v8 (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | test/inspector/debugger/framework-break.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 6209 matching lines...) Expand 10 before | Expand all | Expand 10 after
6220 6220
6221 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, 6221 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints,
6222 name_should_print_as_anonymous, kNameShouldPrintAsAnonymous) 6222 name_should_print_as_anonymous, kNameShouldPrintAsAnonymous)
6223 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, is_anonymous_expression, 6223 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, is_anonymous_expression,
6224 kIsAnonymousExpression) 6224 kIsAnonymousExpression)
6225 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, deserialized, kDeserialized) 6225 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, deserialized, kDeserialized)
6226 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, has_no_side_effect, 6226 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, has_no_side_effect,
6227 kHasNoSideEffect) 6227 kHasNoSideEffect)
6228 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_has_no_side_effect, 6228 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_has_no_side_effect,
6229 kComputedHasNoSideEffect) 6229 kComputedHasNoSideEffect)
6230 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, debug_is_blackboxed,
6231 kDebugIsBlackboxed)
6232 BOOL_ACCESSORS(SharedFunctionInfo, debugger_hints, computed_debug_is_blackboxed,
6233 kComputedDebugIsBlackboxed)
6230 6234
6231 bool Script::HasValidSource() { 6235 bool Script::HasValidSource() {
6232 Object* src = this->source(); 6236 Object* src = this->source();
6233 if (!src->IsString()) return true; 6237 if (!src->IsString()) return true;
6234 String* src_str = String::cast(src); 6238 String* src_str = String::cast(src);
6235 if (!StringShape(src_str).IsExternal()) return true; 6239 if (!StringShape(src_str).IsExternal()) return true;
6236 if (src_str->IsOneByteRepresentation()) { 6240 if (src_str->IsOneByteRepresentation()) {
6237 return ExternalOneByteString::cast(src)->resource() != NULL; 6241 return ExternalOneByteString::cast(src)->resource() != NULL;
6238 } else if (src_str->IsTwoByteRepresentation()) { 6242 } else if (src_str->IsTwoByteRepresentation()) {
6239 return ExternalTwoByteString::cast(src)->resource() != NULL; 6243 return ExternalTwoByteString::cast(src)->resource() != NULL;
(...skipping 2202 matching lines...) Expand 10 before | Expand all | Expand 10 after
8442 #undef WRITE_INT64_FIELD 8446 #undef WRITE_INT64_FIELD
8443 #undef READ_BYTE_FIELD 8447 #undef READ_BYTE_FIELD
8444 #undef WRITE_BYTE_FIELD 8448 #undef WRITE_BYTE_FIELD
8445 #undef NOBARRIER_READ_BYTE_FIELD 8449 #undef NOBARRIER_READ_BYTE_FIELD
8446 #undef NOBARRIER_WRITE_BYTE_FIELD 8450 #undef NOBARRIER_WRITE_BYTE_FIELD
8447 8451
8448 } // namespace internal 8452 } // namespace internal
8449 } // namespace v8 8453 } // namespace v8
8450 8454
8451 #endif // V8_OBJECTS_INL_H_ 8455 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | test/inspector/debugger/framework-break.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698