[inspector] implemented blackboxing inside v8

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 9024 matching lines @@
 void debug::PrepareStep(Isolate* v8_isolate, StepAction action) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
   ENTER_V8(isolate);
   CHECK(isolate->debug()->CheckExecutionState());
   // Clear all current stepping setup.
   isolate->debug()->ClearStepping();
   // Prepare step.
   isolate->debug()->PrepareStep(static_cast<i::StepAction>(action));
 }
 
-void debug::ClearStepping(Isolate* v8_isolate) {
-  i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
-  ENTER_V8(isolate);
-  // Clear all current stepping setup.
-  isolate->debug()->ClearStepping();
-}
-
 v8::Isolate* debug::Script::GetIsolate() const {
   return reinterpret_cast<v8::Isolate*>(Utils::OpenHandle(this)->GetIsolate());
 }
 
 ScriptOriginOptions debug::Script::OriginOptions() const {
   return Utils::OpenHandle(this)->origin_options();
 }
 
 bool debug::Script::WasCompiled() const {
   return Utils::OpenHandle(this)->compilation_state() ==
@@ skipping 71 matching lines @@
   i::Handle<i::Object> value(script->source(), isolate);
   if (!value->IsString()) return MaybeLocal<String>();
   return Utils::ToLocal(
       handle_scope.CloseAndEscape(i::Handle<i::String>::cast(value)));
 }
 
 bool debug::Script::IsWasm() const {
   return Utils::OpenHandle(this)->type() == i::Script::TYPE_WASM;
 }
 
+void debug::Script::BlackboxStateChanged() const {

[dgozman, 2017/01/19 21:49:14]

Why doesn't this get a bool parameter |blackboxed|?

[kozy, 2017/01/20 02:32:36]

After offline discussion we decided to try to introduce least possible new
structures and new fields internally in V8.
Advantages:
- API without any JS allocation,
- blackboxed state logic computation is located inside of V8DebuggerAgentImpl.
Disadvantage:
- two methods in API instead of one.

+  i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
+  i::HandleScope handle_scope(isolate);
+  i::Handle<i::Script> script = Utils::OpenHandle(this);
+  i::SharedFunctionInfo::ScriptIterator iterator(script);
+  for (i::SharedFunctionInfo* info = iterator.Next(); info != nullptr;
+       info = iterator.Next()) {
+    info->set_computed_debug_is_blackboxed(false);
+  }
+}
+
 namespace {
 int GetSmiValue(i::Handle<i::FixedArray> array, int index) {
   return i::Smi::cast(array->get(index))->value();
 }
 }  // namespace
 
 bool debug::Script::GetPossibleBreakpoints(
     const debug::Location& start, const debug::Location& end,
     std::vector<debug::Location>* locations) const {
   CHECK(!start.IsEmpty());
@@ skipping 168 matching lines @@
   RETURN_ESCAPED(ToApiHandle<UnboundScript>(result));
 }
 
 void debug::SetDebugEventListener(Isolate* v8_isolate,
                                   debug::DebugEventListener* listener) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
   ENTER_V8(isolate);
   isolate->debug()->SetDebugEventListener(listener);
 }
 
+void debug::SetIsBlackboxedCallback(Isolate* v8_isolate,
+                                    IsBlackboxedCallback callback, void* data) {
+  i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
+  ENTER_V8(isolate);
+  isolate->debug()->SetIsBlackboxedCallback(callback, data);
+}
+
+bool debug::HasUserFrameOnStack(Isolate* v8_isolate) {
+  i::Isolate* isolate = reinterpret_cast<i::Isolate*>(v8_isolate);
+  ENTER_V8(isolate);
+  for (i::StackTraceFrameIterator it(isolate); !it.done(); it.Advance()) {
+    if (!it.is_javascript()) continue;
+    if (!it.javascript_frame()->function()->shared()->DebugIsBlackboxed())
+      return true;
+  }
+  return false;
+}
+
 Local<String> CpuProfileNode::GetFunctionName() const {
   const i::ProfileNode* node = reinterpret_cast<const i::ProfileNode*>(this);
   i::Isolate* isolate = node->isolate();
   const i::CodeEntry* entry = node->entry();
   i::Handle<i::String> name =
       isolate->factory()->InternalizeUtf8String(entry->name());
   if (!entry->has_name_prefix()) {
     return ToApiHandle<String>(name);
   } else {
     // We do not expect this to fail. Change this if it does.
@@ skipping 672 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8