android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml - Issue 2633733002: Convert WebView Layout test to JUnit4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml

Issue 2633733002: Convert WebView Layout test to JUnit4 (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/tools/system_webview_shell/BUILD.gn ('k') | android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java » ('j') | android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml

diff --git a/android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml b/android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml

index 00ebd4c59cee64f53b09480894fab9d888daeadc..9c9cc9729a1b5ddb7fe39a5beee68b1b6f67bf1e 100644

--- a/android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml

+++ b/android_webview/tools/system_webview_shell/layout_tests/AndroidManifest.xml

@@ -30,7 +30,8 @@

android:exported="true"/>

</application>

- <instrumentation android:name="org.chromium.webview_shell.test.WebViewLayoutTestRunner"

+ <instrumentation android:name="android.support.test.runner.AndroidJUnitRunner"

android:targetPackage="org.chromium.webview_shell"

- android:label="Layout tests for org.chromium.webview_shell" />

+ android:label="Android JUnit 4 runner"

timvolodine 2017/02/16 23:37:24 why not keep the label?

the real yoland 2017/02/17 01:15:13 Done

+ chromium-junit4="true"/>

</manifest>