Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: net/cookies/cookie_monster.h

Issue 2633663003: Implements strict secure cookies as the default behavior in //net (Closed)
Patch Set: Rebase on ToT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index 52d43206f322d9eddf62db4193600107e809bf16..ff7c47f8b0a419348981c886ed2da9414d46ad0e 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -164,7 +164,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
bool secure,
bool http_only,
CookieSameSite same_site,
- bool enforce_strict_secure,
CookiePriority priority,
const SetCookiesCallback& callback) override;
void GetCookiesWithOptionsAsync(const GURL& url,
@@ -265,13 +264,11 @@ class NET_EXPORT CookieMonster : public CookieStore {
FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest, CookieSourceHistogram);
// For kSafeFromGlobalPurgeDays in CookieStore.
- FRIEND_TEST_ALL_PREFIXES(CookieMonsterStrictSecureTest, EvictSecureCookies);
+ FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest, EvictSecureCookies);
// For CookieDeleteEquivalent histogram enum.
FRIEND_TEST_ALL_PREFIXES(CookieMonsterTest,
CookieDeleteEquivalentHistogramTest);
- FRIEND_TEST_ALL_PREFIXES(CookieMonsterStrictSecureTest,
- CookieDeleteEquivalentHistogramTest);
// Internal reasons for deletion, used to populate informative histograms
// and to provide a public cause for onCookieChange notifications.
@@ -412,7 +409,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
bool secure,
bool http_only,
CookieSameSite same_site,
- bool enforce_strict_secure,
CookiePriority priority);
CookieList GetAllCookies();
@@ -508,17 +504,15 @@ class NET_EXPORT CookieMonster : public CookieStore {
// |source_url| is the URL that is attempting to set the cookie.
// If |skip_httponly| is true, httponly cookies will not be deleted. The
// return value will be true if |skip_httponly| skipped an httponly cookie or
- // |enforce_strict_secure| is true and the cookie to
- // delete was Secure and the scheme of |ecc| is insecure. |key| is the key to
- // find the cookie in cookies_; see the comment before the CookieMap typedef
- // for details.
+ // the cookie to delete was Secure and the scheme of |ecc| is insecure. |key|
+ // is the key to find the cookie in cookies_; see the comment before the
+ // CookieMap typedef for details.
// NOTE: There should never be more than a single matching equivalent cookie.
bool DeleteAnyEquivalentCookie(const std::string& key,
const CanonicalCookie& ecc,
const GURL& source_url,
bool skip_httponly,
- bool already_expired,
- bool enforce_strict_secure);
+ bool already_expired);
// Inserts |cc| into cookies_. Returns an iterator that points to the inserted
// cookie in cookies_. Guarantee: all iterators to cookies_ remain valid.
@@ -562,9 +556,7 @@ class NET_EXPORT CookieMonster : public CookieStore {
// constants for details.
//
// Returns the number of cookies deleted (useful for debugging).
- size_t GarbageCollect(const base::Time& current,
- const std::string& key,
- bool enforce_strict_secure);
+ size_t GarbageCollect(const base::Time& current, const std::string& key);
// Helper for GarbageCollect(). Deletes up to |purge_goal| cookies with a
// priority less than or equal to |priority| from |cookies|, while ensuring
« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | net/cookies/cookie_monster.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698