Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: headless/public/util/generic_url_request_job_test.cc

Issue 2633663003: Implements strict secure cookies as the default behavior in //net (Closed)
Patch Set: Rebase on ToT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/generic_url_request_job_test.cc
diff --git a/headless/public/util/generic_url_request_job_test.cc b/headless/public/util/generic_url_request_job_test.cc
index e1942f86e8be5b3fa255e0d72b1b4bc0bf8921d0..79dc9e2bf5203ddfdff0f7bb25d6b745af8dbc1f 100644
--- a/headless/public/util/generic_url_request_job_test.cc
+++ b/headless/public/util/generic_url_request_job_test.cc
@@ -281,7 +281,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
base::Time(), base::Time(),
/* secure */ false,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Matching secure cookie.
cookies->push_back(*net::CanonicalCookie::Create(
@@ -289,7 +289,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
base::Time(), base::Time(),
/* secure */ true,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ true, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Matching http-only cookie.
cookies->push_back(*net::CanonicalCookie::Create(
@@ -297,7 +297,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
base::Time(), base::Time(),
/* secure */ false,
/* http_only */ true, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Matching cookie with path.
cookies->push_back(*net::CanonicalCookie::Create(
@@ -305,7 +305,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
"/widgets", base::Time(), base::Time(),
/* secure */ false,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Matching cookie with subdomain.
cookies->push_back(*net::CanonicalCookie::Create(
@@ -313,7 +313,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
"cdn.example.com", "/", base::Time(), base::Time(),
/* secure */ false,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Non-matching cookie (different site).
cookies->push_back(*net::CanonicalCookie::Create(
@@ -321,7 +321,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
base::Time(), base::Time(),
/* secure */ false,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
// Non-matching cookie (different path).
cookies->push_back(*net::CanonicalCookie::Create(
@@ -329,7 +329,7 @@ TEST_F(GenericURLRequestJobTest, RequestWithCookies) {
"/gadgets", base::Time(), base::Time(),
/* secure */ false,
/* http_only */ false, net::CookieSameSite::NO_RESTRICTION,
- /* enforce_strict_secure */ false, net::COOKIE_PRIORITY_DEFAULT));
+ net::COOKIE_PRIORITY_DEFAULT));
std::string reply =
"{\"url\":\"https://example.com\","
« no previous file with comments | « content/shell/browser/shell_network_delegate.cc ('k') | headless/public/util/testing/generic_url_request_mocks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698