Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: content/browser/frame_host/render_frame_message_filter.cc

Issue 2633663003: Implements strict secure cookies as the default behavior in //net (Closed)
Patch Set: Rebase on ToT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_message_filter.cc
diff --git a/content/browser/frame_host/render_frame_message_filter.cc b/content/browser/frame_host/render_frame_message_filter.cc
index 93a1da4df0c069433eb6020cd198a722929658af..0dd8d8b5004bd067d9d5ff38d1ed6c2c5a75dc2b 100644
--- a/content/browser/frame_host/render_frame_message_filter.cc
+++ b/content/browser/frame_host/render_frame_message_filter.cc
@@ -6,7 +6,6 @@
#include "base/command_line.h"
#include "base/macros.h"
-#include "base/metrics/field_trial.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
#include "content/browser/bad_message.h"
@@ -26,7 +25,6 @@
#include "content/public/browser/download_manager.h"
#include "content/public/browser/download_url_parameters.h"
#include "content/public/common/content_constants.h"
-#include "content/public/common/content_switches.h"
#include "gpu/GLES2/gl2extchromium.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "net/cookies/cookie_options.h"
@@ -57,8 +55,6 @@ namespace {
const int kPluginsRefreshThresholdInSeconds = 3;
#endif
-const char kEnforceStrictSecureExperiment[] = "StrictSecureCookies";
-
void CreateChildFrameOnUI(int process_id,
int parent_routing_id,
blink::WebTreeScopeType scope,
@@ -396,16 +392,6 @@ void RenderFrameMessageFilter::SetCookie(int32_t render_frame_id,
}
net::CookieOptions options;
- bool experimental_web_platform_features_enabled =
- base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableExperimentalWebPlatformFeatures);
- const std::string enforce_strict_secure_group =
- base::FieldTrialList::FindFullName(kEnforceStrictSecureExperiment);
- if (experimental_web_platform_features_enabled ||
- base::StartsWith(enforce_strict_secure_group, "Enabled",
- base::CompareCase::INSENSITIVE_ASCII)) {
- options.set_enforce_strict_secure();
- }
if (GetContentClient()->browser()->AllowSetCookie(
url, first_party_for_cookies, cookie, resource_context_,
render_process_id_, render_frame_id, options)) {
« no previous file with comments | « content/browser/devtools/protocol/network_handler.cc ('k') | content/browser/net/quota_policy_cookie_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698