chrome/test/data/extensions/api_test/cookies/api/tab.js - Issue 2633663003: Implements strict secure cookies as the default behavior in //net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/cookies/api/tab.js

Issue 2633663003: Implements strict secure cookies as the default behavior in //net (Closed)

Patch Set: Rebase on ToT Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/extensions/api_test/cookies/api/tab.js

diff --git a/chrome/test/data/extensions/api_test/cookies/api/tab.js b/chrome/test/data/extensions/api_test/cookies/api/tab.js

index cb5caf258be36da3c6454b2048ceb7c0847d9628..3bb210e60677b308c80535f24fe471811d1874c4 100644

--- a/chrome/test/data/extensions/api_test/cookies/api/tab.js

+++ b/chrome/test/data/extensions/api_test/cookies/api/tab.js

@@ -29,7 +29,7 @@ var TEST_DOMAIN_COOKIE = {

expirationDate: TEST_EXPIRATION_DATE

};

var TEST_SECURE_COOKIE = {

- url: TEST_URL5,

+ url: TEST_URL4,

name: 'SECRETCOOKIE',

value: 'foobar_password',

secure: true,

@@ -163,9 +163,9 @@ chrome.test.runTests([

function getSecureCookie() {

removeTestCookies();

chrome.cookies.set(TEST_SECURE_COOKIE, pass(function () {

- // Original URL doesn't work because scheme isn't secure.

+ // URL doesn't work because scheme isn't secure.

chrome.cookies.get(

- {url: TEST_SECURE_COOKIE.url, name: TEST_SECURE_COOKIE.name},

+ {url: TEST_URL5, name: TEST_SECURE_COOKIE.name},

pass(expectNullCookie));

// Path doesn't match.

chrome.cookies.get(