Source/platform/fonts/Font.cpp - Issue 263363005: Initial patch for FontVariant, variant like HalfWidth should take Complex Path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 263363005: Initial patch for FontVariant, variant like HalfWidth should take Complex Path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@emoji_android

Patch Set: Updating test case Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/text/font-variant-width-expected.txt ('K') | « LayoutTests/fast/text/font-variant-width-expected.txt ('k') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index 8a1556ce5daf8308e9c054f07195a5c76d1ba101..2a4756e0be341ea21c908fee00fd1a72fe242d9d 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -232,6 +232,9 @@ CodePath Font::codePath(const TextRun& run) const

if (m_fontDescription.featureSettings() && m_fontDescription.featureSettings()->size() > 0)

return ComplexPath;

+ if (m_fontDescription.widthVariant() != RegularWidth)

+ return ComplexPath;

if (run.length() > 1 && !WidthIterator::supportsTypesettingFeatures(*this))

return ComplexPath;