LayoutTests/fast/text/font-variant-width.html - Issue 263363005: Initial patch for FontVariant, variant like HalfWidth should take Complex Path

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text/font-variant-width.html

Issue 263363005: Initial patch for FontVariant, variant like HalfWidth should take Complex Path (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@emoji_android

Patch Set: Updating test case Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>
	Inactive 2014/05/22 13:59:51 lowercase "html" lowercase "html" h.joshi 2014/05/27 06:25:57 Will make changes. Will make changes.
	2 <html>

	3 <head>

	4 <style type="text/css">
	Inactive 2014/05/22 13:59:51 Why this style tag? Why this style tag? h.joshi 2014/05/27 06:25:57 Will remove this Will remove this
	5 </style>

	6 <style>

	7 @font-face {

	8 font-family: CSSHWOrientationTest;

	9 src: url(../../third_party/CSSOrientationTest/CSSHWOrientationTest.ttf) format ("truetype");

	10 }

	11

	12 html {

	13 -webkit-writing-mode: vertical-rl;

	14 text-rendering: geometricPrecision;

	15 }

	16

	17 p {

	18 font-family: "CSSHWOrientationTest";

	19 font-size: 24px;

	20 width: 24px;

	21 height: 24px;

	22 margin: 0;

	23 padding: 0;

	24 }

	25

	26 .combine {

	27 -webkit-text-combine: horizontal;

	28 font-size: 24px;

	29 line-height: 100%;

	30 margin: 0;

	31 padding: 0px;

	32 }

	33

	34

	35 </style>

	36 <script src="../../resources/testharness.js"></script>

	37 <script src="../../resources/testharnessreport.js"></script>

	38

	39 <script type="text/javascript">

	40 setup({ explicit_done: true });

	41 function load() {

	42 var spanElement = document.getElementById("variantCombine");

	43 var propertyHeight = document.querySelector('.combine').client Height;

	44

	45 test(function() {

	46 assert_true(( propertyHeight == 24), "Numbers laid out in one line.");
	Inactive 2014/05/22 13:59:51 assert_equals(propertyHeight, 24, "Numbers are lai assert_equals(propertyHeight, 24, "Numbers are laid out in one line."); h.joshi 2014/05/27 06:25:57 Okey, will make suggested changes. Okey, will make suggested changes.
	47 }, "Numbers exected to be laid out in one line");
	Inactive 2014/05/22 13:59:51 s/exected/expected s/exected/expected h.joshi 2014/05/27 06:25:57 Okey, will make suggested changes. Okey, will make suggested changes.
	48 }

	49 </script>

	50 </head>
	Inactive 2014/05/22 13:59:51 bad indentation bad indentation h.joshi 2014/05/27 06:25:57 Some issue with my editor, will fix indentation. Some issue with my editor, will fix indentation.
	51

	52 <body onload="load(); done();">
	Inactive 2014/05/22 13:59:51 bad indentation bad indentation h.joshi 2014/05/27 06:25:57 Some issue with my editor, will fix indentation. Some issue with my editor, will fix indentation.
	53 <p id="variantCombine" class="combine">90</p>

	54 <div id="log"></div>
	Inactive 2014/05/22 13:59:51 bad identation bad identation h.joshi 2014/05/27 06:25:57 Some issue with my editor, will fix indentation. Some issue with my editor, will fix indentation.
	55 </body>

	56 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/text/font-variant-width-expected.txt » ('j') | LayoutTests/fast/text/font-variant-width-expected.txt » ('J')