MediaRecorder: handle libwebm::Segment::AddFrame() errors and wire up to Blink

content/renderer/media/media_recorder_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_recorder_handler.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 248 matching lines @@
 }
 
 void MediaRecorderHandler::OnEncodedVideo(
     const media::WebmMuxer::VideoParameters& params,
     std::unique_ptr<std::string> encoded_data,
     TimeTicks timestamp,
     bool is_key_frame) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
   if (!webm_muxer_)
     return;
-  webm_muxer_->OnEncodedVideo(params, std::move(encoded_data), timestamp,
-                              is_key_frame);
+  if (!webm_muxer_->OnEncodedVideo(params, std::move(encoded_data), timestamp,
+                                   is_key_frame)) {
+    DLOG(ERROR) << "Error muxing video data";
+    client_->onError("Error muxing video data");
+  }
 }
 
 void MediaRecorderHandler::OnEncodedAudio(
     const media::AudioParameters& params,
     std::unique_ptr<std::string> encoded_data,
     base::TimeTicks timestamp) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
-  if (webm_muxer_)
-    webm_muxer_->OnEncodedAudio(params, std::move(encoded_data), timestamp);
+  if (!webm_muxer_)
+    return;
+  if (!webm_muxer_->OnEncodedAudio(params, std::move(encoded_data),
+                                   timestamp)) {
+    DLOG(ERROR) << "Error muxing audio data";
+    client_->onError("Error muxing audio data");
+  }
 }
 
 void MediaRecorderHandler::WriteData(base::StringPiece data) {
   DCHECK(main_render_thread_checker_.CalledOnValidThread());
   const TimeTicks now = TimeTicks::Now();
   // Non-buffered mode does not need to check timestamps.
   if (timeslice_.is_zero()) {
     client_->writeData(data.data(), data.length(), true /* lastInSlice */,
                        (now - TimeTicks::UnixEpoch()).InMillisecondsF());
     return;
@@ skipping 21 matching lines @@
     recorder->OnData(audio_bus, timestamp);
 }
 
 void MediaRecorderHandler::SetAudioFormatForTesting(
     const media::AudioParameters& params) {
   for (const auto& recorder : audio_recorders_)
     recorder->OnSetFormat(params);
 }
 
 }  // namespace content