Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2806)

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2633603002: Disable app banners in incognito. (Closed)
Patch Set: Comment + rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 9fd06cf0678447f2fd9fe581c428e70e4565e6fb..c580176e5b763d691ce0d498d97ea27a4f5fe03b 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -61,6 +61,8 @@ static const char kIdsDoNotMatchMessage[] =
"but they do not match";
static const char kUrlNotSupportedForWebApkMessage[] =
"a URL in the web manifest contains a username, password, or port";
+static const char kInIncognitoMessage[] =
+ "the page is loaded in an incognito window";
} // namespace
@@ -145,6 +147,9 @@ void LogErrorToConsole(content::WebContents* web_contents,
case URL_NOT_SUPPORTED_FOR_WEBAPK:
pattern = kUrlNotSupportedForWebApkMessage;
break;
+ case IN_INCOGNITO:
+ pattern = kInIncognitoMessage;
+ break;
}
if (!pattern)
« no previous file with comments | « chrome/browser/installable/installable_logging.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698