Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2633603002: Disable app banners in incognito. (Closed)
Patch Set: Comment + rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index daf4d446b79bebc15217a201ec3400bf1bec0d79..7d81050bb240ed61355e6480179b97e8ef5a41bb 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -573,6 +573,46 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@SmallTest
@Feature({"AppBanners"})
+ public void testBannerAppearsImmediatelyWithSufficientEngagement() throws Exception {
+ // Visit the site in a new tab with sufficient engagement and verify it appears.
+ resetEngagementForUrl(mWebAppUrl, 10);
+ loadUrlInNewTab("about:blank");
+
+ new TabLoadObserver(getActivity().getActivityTab())
+ .fullyLoadUrl(mWebAppUrl, PageTransition.TYPED);
+
+ CriteriaHelper.pollUiThread(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
+ return !manager.isActiveForTesting();
+ }
+ });
+ waitUntilAppBannerInfoBarAppears(WEB_APP_TITLE);
+ }
+
+ @SmallTest
+ @Feature({"AppBanners"})
+ public void testBannerDoesNotAppearInIncognito() throws Exception {
+ // Visit the site in an incognito tab and verify it doesn't appear.
+ resetEngagementForUrl(mWebAppUrl, 10);
+ loadUrlInNewTab("about:blank", true);
+
+ new TabLoadObserver(getActivity().getActivityTab())
+ .fullyLoadUrl(mWebAppUrl, PageTransition.TYPED);
+
+ CriteriaHelper.pollUiThread(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
+ return !manager.isActiveForTesting();
+ }
+ });
+ assertTrue(getInfoBars().isEmpty());
+ }
+
+ @SmallTest
+ @Feature({"AppBanners"})
public void testWebAppSplashscreenIsDownloaded() throws Exception {
// Sets the overriden factory to observer splash screen update.
final TestDataStorageFactory dataStorageFactory = new TestDataStorageFactory();
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698