Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4882)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2633603002: Disable app banners in incognito. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index ee3b521bccd7a6b452bf1433fdbaf5ded7c1bf03..5292a826ada679ebf63a39fff2eb83a12d2cda28 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -579,6 +579,46 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
@SmallTest
@Feature({"AppBanners"})
+ public void testBannerAppearsImmediatelyWithSufficientEngagement() throws Exception {
+ // Visit the site in a new tab with sufficient engagement and verify it appears.
+ resetEngagementForUrl(mWebAppUrl, 10);
+ loadUrlInNewTab("about:blank");
+
+ new TabLoadObserver(getActivity().getActivityTab())
+ .fullyLoadUrl(mWebAppUrl, PageTransition.TYPED);
+
+ CriteriaHelper.pollUiThread(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
+ return !manager.isActiveForTesting();
+ }
+ });
+ waitUntilAppBannerInfoBarAppears(WEB_APP_TITLE);
+ }
+
+ @SmallTest
+ @Feature({"AppBanners"})
+ public void testBannerDoesNotAppearInIncognito() throws Exception {
+ // Visit the site in an incognito tab and verify it doesn't appear.
+ resetEngagementForUrl(mWebAppUrl, 10);
+ loadUrlInNewTab("about:blank", true);
+
+ new TabLoadObserver(getActivity().getActivityTab())
+ .fullyLoadUrl(mWebAppUrl, PageTransition.TYPED);
+
+ CriteriaHelper.pollUiThread(new Criteria() {
+ @Override
+ public boolean isSatisfied() {
+ AppBannerManager manager = getActivity().getActivityTab().getAppBannerManager();
+ return !manager.isActiveForTesting();
+ }
+ });
+ waitUntilNoInfoBarsExist();
benwells 2017/01/13 04:48:16 You may need to update this if another patch lands
dominickn 2017/01/13 04:55:32 Acknowledged.
+ }
+
+ @SmallTest
+ @Feature({"AppBanners"})
public void testWebAppSplashscreenIsDownloaded() throws Exception {
// Sets the overriden factory to observer splash screen update.
final TestDataStorageFactory dataStorageFactory = new TestDataStorageFactory();
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | chrome/browser/banners/app_banner_manager_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698