Disable app banners in incognito.

chrome/browser/banners/app_banner_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 61 matching lines @@
 // static
 bool AppBannerManager::URLsAreForTheSamePage(const GURL& first,
                                              const GURL& second) {
   return first.GetWithEmptyPath() == second.GetWithEmptyPath() &&
          first.path_piece() == second.path_piece() &&
          first.query_piece() == second.query_piece();
 }
 
 void AppBannerManager::RequestAppBanner(const GURL& validated_url,
                                         bool is_debug_mode) {
+  content::WebContents* contents = web_contents();
+
   // Don't start a redundant banner request. Otherwise, if one is running,
   // invalidate our weak pointers so it terminates.
-  content::WebContents* contents = web_contents();
   if (is_active_) {
     if (URLsAreForTheSamePage(validated_url, contents->GetLastCommittedURL()))
       return;
     else
       weak_factory_.InvalidateWeakPtrs();
   }
 
   is_active_ = true;
   is_debug_mode_ = is_debug_mode;
 
   // We only need to call ReportStatus if we aren't in debug mode (this avoids
   // skew from testing).
   DCHECK(!need_to_log_status_);
   need_to_log_status_ = !IsDebugMode();
 
-  if (contents->GetMainFrame()->GetParent()) {
-    ReportStatus(contents, NOT_IN_MAIN_FRAME);
+  // Exit if this is an incognito window, non-main frame, or insecure context.
+  InstallableStatusCode code = NO_ERROR_DETECTED;
+  if (Profile::FromBrowserContext(contents->GetBrowserContext())
+          ->IsOffTheRecord()) {
+    code = IN_INCOGNITO;
+  } else if (contents->GetMainFrame()->GetParent()) {
+    code = NOT_IN_MAIN_FRAME;
+  } else if (!InstallableManager::IsContentSecure(contents)) {
+    code = NOT_FROM_SECURE_ORIGIN;
+  }
+
+  if (code != NO_ERROR_DETECTED) {
+    ReportStatus(contents, code);
     Stop();
     return;
   }
-
-  // A secure origin is required to show banners, so exit early if we see the
-  // URL is invalid.
-  if (!InstallableManager::IsContentSecure(contents)) {
-    ReportStatus(contents, NOT_FROM_SECURE_ORIGIN);
-    Stop();
-    return;
-  }
 
   if (validated_url_.is_empty())
     validated_url_ = validated_url;
 
   // Any existing binding is invalid when we request a new banner.
   if (binding_.is_bound())
     binding_.Close();
 
   manager_->GetData(
       ParamsToGetManifest(),
@@ skipping 404 matching lines @@
     // Simulate a non-canceled OnBannerPromptReply to show the delayed banner.
     // Don't reset |was_canceled_by_page_| yet for metrics purposes.
     OnBannerPromptReply(blink::mojom::AppBannerPromptReply::NONE, referrer_);
   } else {
     // Log that the prompt request was made for when we get the prompt reply.
     page_requested_prompt_ = true;
   }
 }
 
 }  // namespace banners