Add Postscript Printing

chrome/browser/printing/pdf_to_emf_converter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRINTING_PDF_TO_EMF_CONVERTER_H_
 #define CHROME_BROWSER_PRINTING_PDF_TO_EMF_CONVERTER_H_
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/memory/ref_counted_memory.h"
 
 namespace printing {
 
 class MetafilePlayer;
 struct PdfRenderSettings;
 
 class PdfToEmfConverter {
  public:

[Vitaly Buka (NO REVIEWS), 2017/01/17 19:29:16]

I'd recommend to submit patches as small as possible. Even such walk-by fixes
should be separate tiny patches. With git it's easy to do so.

It will simplify reviews, and make later debugging (using bisect) much easier.

-  typedef base::Callback<void(int page_count)> StartCallback;
-  typedef base::Callback<void(int page_number,
-                              float scale_factor,
-                              std::unique_ptr<MetafilePlayer> emf)>
-      GetPageCallback;
+  using StartCallback = base::Callback<void(int page_count)>;
+  using GetPageCallback =
+      base::Callback<void(int page_number,
+                          float scale_factor,
+                          std::unique_ptr<MetafilePlayer> emf)>;
 
   virtual ~PdfToEmfConverter();
 
   static std::unique_ptr<PdfToEmfConverter> CreateDefault();
 
   // Starts conversion of PDF provided as |data|. Calls |start_callback|
   // with positive |page_count|. |page_count| is 0 if initialization failed.
   virtual void Start(const scoped_refptr<base::RefCountedMemory>& data,
                      const PdfRenderSettings& conversion_settings,
-                     bool print_text_with_gdi,
                      const StartCallback& start_callback) = 0;
 
   // Requests conversion of the page. |page_number| is 0-base page number in
+  // PDF provided in Start() call.
+  // Calls |get_page_callback| after conversion. |emf| of callback in not NULL
+  // if conversion succeeded.
+  virtual void GetPage(int page_number,
+                       const GetPageCallback& get_page_callback) = 0;
+};
+
+class PdfToPostScriptConverter {

[Vitaly Buka (NO REVIEWS), 2017/01/17 19:29:16]

why not separate pair of h/cc file
git probably would detect copied files, so we can see how they are actually
different

+ public:
+  using StartCallback = base::Callback<void(int page_count)>;
+  using GetPageCallback =
+      base::Callback<void(int page_number,
+                          std::unique_ptr<MetafilePlayer> ps_metafile)>;
+
+  virtual ~PdfToPostScriptConverter();
+
+  static std::unique_ptr<PdfToPostScriptConverter> CreateDefault();
+
+  // Starts conversion of PDF provided as |data|. Calls |start_callback|
+  // with positive |page_count|. |page_count| is 0 if initialization failed.
+  virtual void Start(const scoped_refptr<base::RefCountedMemory>& data,
+                     const PdfRenderSettings& conversion_settings,
+                     const StartCallback& start_callback) = 0;
+
+  // Requests conversion of the page. |page_number| is 0-base page number in
   // PDF provided in Start() call.
   // Calls |get_page_callback| after conversion. |emf| of callback in not NULL
   // if conversion succeeded.
   virtual void GetPage(int page_number,
                        const GetPageCallback& get_page_callback) = 0;
 };
 
 }  // namespace printing
 
 #endif  // CHROME_BROWSER_PRINTING_PDF_TO_EMF_CONVERTER_H_