Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2633543003: Revert "Support spawnUri in app snapshots." (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Support spawnUri in app snapshots." This reverts commit 593d4504b0e7b9a8c2b920da1d341c8e55ce58ad. This reverts commit 113aa64b9849df42353423f8a34d56d4839ad3a8. This reverts commit 422afa2eadb57eb50bd763d4cc3f790f63fc6fc2. Committed: https://github.com/dart-lang/sdk/commit/f89056f6cda6fd82208b954a3f53a5e1f27b1862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -89 lines) Patch
M runtime/bin/main.cc View 12 chunks +16 lines, -56 lines 0 comments Download
M runtime/bin/snapshot_empty.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/snapshot_in.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/metrics_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/zone_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M utils/application_snapshot.gni View 1 chunk +45 lines, -0 lines 0 comments Download
M utils/pub/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
rmacnak
3 years, 11 months ago (2017-01-13 19:02:51 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f89056f6cda6fd82208b954a3f53a5e1f27b1862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698