Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1470)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc

Issue 2633523003: Record data: URL metrics for mime types that can run JavaScript. (Closed)
Patch Set: Remove logging Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc b/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
index 5318d9837004480fe8a9471b363f328db9ee9d8e..a192d04520f92ec5ea7602f7e4ac63341b1709bb 100644
--- a/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
+++ b/chrome/browser/tab_contents/navigation_metrics_recorder_browsertest.cc
@@ -17,6 +17,14 @@ namespace {
typedef InProcessBrowserTest NavigationMetricsRecorderBrowserTest;
+// Performs a content initiated navigation to |url|.
+void RedirectToUrl(content::WebContents* web_contents, const GURL& url) {
+ content::TestNavigationObserver observer(web_contents, 1);
+ EXPECT_TRUE(content::ExecuteScript(
+ web_contents, std::string("window.location.href='") + url.spec() + "'"));
+ observer.Wait();
+}
+
IN_PROC_BROWSER_TEST_F(NavigationMetricsRecorderBrowserTest, TestMetrics) {
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -53,4 +61,57 @@ IN_PROC_BROWSER_TEST_F(NavigationMetricsRecorderBrowserTest, TestMetrics) {
EXPECT_EQ(rappor::ETLD_PLUS_ONE_RAPPOR_TYPE, type);
}
+IN_PROC_BROWSER_TEST_F(NavigationMetricsRecorderBrowserTest, DataURLMimeTypes) {
+ base::HistogramTester histograms;
+ content::WebContents* web_contents =
+ browser()->tab_strip_model()->GetActiveWebContents();
+
+ // HTML:
+ RedirectToUrl(web_contents, GURL("data:text/html, <html></html>"));
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme", 1);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme", 5 /* data: */, 1);
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme.DataUrl.MimeType", 1);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme.DataUrl.MimeType",
+ NavigationMetricsRecorder::MIME_TYPE_HTML, 1);
+
+ // SVG:
+ RedirectToUrl(web_contents,
+ GURL("data:image/svg+xml,<!DOCTYPE svg><svg version=\"1.1\" "
+ "xmlns=\"http://www.w3.org/2000/svg\"></svg>"));
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme", 2);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme", 5 /* data: */, 2);
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme.DataUrl.MimeType", 2);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme.DataUrl.MimeType",
+ NavigationMetricsRecorder::MIME_TYPE_SVG, 1);
+
+ // Base64 encoded HTML:
+ RedirectToUrl(web_contents,
+ GURL("data:text/html;base64, PGh0bWw+YmFzZTY0PC9odG1sPg=="));
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme", 3);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme", 5 /* data: */, 3);
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme.DataUrl.MimeType", 3);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme.DataUrl.MimeType",
+ NavigationMetricsRecorder::MIME_TYPE_HTML, 2);
+
+ // Plain text:
+ RedirectToUrl(web_contents, GURL("data:text/plain, test"));
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme", 4);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme", 5 /* data: */, 4);
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme.DataUrl.MimeType", 4);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme.DataUrl.MimeType",
+ NavigationMetricsRecorder::MIME_TYPE_OTHER, 1);
+
+ // Base64 encoded PNG:
+ RedirectToUrl(
+ web_contents,
+ GURL("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUA"
+ "AAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO"
+ "9TXL0Y4OHwAAAABJRU5ErkJggg=="));
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme", 5);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme", 5 /* data: */, 5);
+ histograms.ExpectTotalCount("Navigation.MainFrameScheme.DataUrl.MimeType", 5);
+ histograms.ExpectBucketCount("Navigation.MainFrameScheme.DataUrl.MimeType",
+ NavigationMetricsRecorder::MIME_TYPE_OTHER, 2);
+}
+
} // namespace
« no previous file with comments | « chrome/browser/tab_contents/navigation_metrics_recorder.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698