Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: ios/net/crn_http_protocol_handler.mm

Issue 2633453004: Remove support for GlobalNetworkClientFactory from RequestTracker. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/net/request_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/crn_http_protocol_handler.mm
diff --git a/ios/net/crn_http_protocol_handler.mm b/ios/net/crn_http_protocol_handler.mm
index d2855b4e2aebe73594100d0c81cdb470557ab22d..c9101f32a091df6f641f13d0938cdbe30a496e0f 100644
--- a/ios/net/crn_http_protocol_handler.mm
+++ b/ios/net/crn_http_protocol_handler.mm
@@ -663,11 +663,6 @@ void HttpProtocolHandlerCore::Start(id<CRNNetworkClientProtocol> base_client) {
if (tracker_) {
// Set up any clients that can operate regardless of the request
PushClients(tracker_->ClientsHandlingAnyRequest());
- } else {
- // There was no request_group_id, so the request was from something like a
- // data: or file: URL.
- // Attach any global clients to the request.
- PushClients(RequestTracker::GlobalClientsHandlingAnyRequest());
sdefresne 2017/01/13 10:29:12 This method was always returning an empty NSArray,
}
// Now that all of the network clients are set up, if there was an error with
« no previous file with comments | « no previous file | ios/net/request_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698