third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp - Issue 2633423003: Leave out empty-valued Access-Control-Request-Headers: on preflights.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

Issue 2633423003: Leave out empty-valued Access-Control-Request-Headers: on preflights. (Closed)

Patch Set: sync unit tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('K') | « third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

index 744bd0f4332ba71861e82b554ab1e27f6577c0d1..facab00ee458ce9229c4b24d292c70ea83330a2b 100644

--- a/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/CrossOriginAccessControlTest.cpp

@@ -48,7 +48,8 @@ TEST_F(CreateAccessControlPreflightRequestTest, ExcludeSimpleHeaders) {

ResourceRequest preflight =

createAccessControlPreflightRequest(request, m_securityOrigin.get());

- EXPECT_EQ("", preflight.httpHeaderField("Access-Control-Request-Headers"));

+ EXPECT_EQ(nullptr,

yhirano 2017/01/18 05:41:55 nullAtom or AtomicString() might be easier to unde

sof 2017/01/18 06:57:48 Using nullAtom instead + added a comment.

+ preflight.httpHeaderField("Access-Control-Request-Headers"));

}

TEST_F(CreateAccessControlPreflightRequestTest,

@@ -59,7 +60,8 @@ TEST_F(CreateAccessControlPreflightRequestTest,

ResourceRequest preflight =

createAccessControlPreflightRequest(request, m_securityOrigin.get());

- EXPECT_EQ("", preflight.httpHeaderField("Access-Control-Request-Headers"));

+ EXPECT_EQ(nullptr,

+ preflight.httpHeaderField("Access-Control-Request-Headers"));

}

TEST_F(CreateAccessControlPreflightRequestTest, IncludeNonSimpleHeader) {