Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: base/metrics/field_trial_unittest.cc

Issue 2633383002: Change FieldTrial::State to not use StringPiece members. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/metrics/field_trial.cc ('K') | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial_unittest.cc
diff --git a/base/metrics/field_trial_unittest.cc b/base/metrics/field_trial_unittest.cc
index 7dcbf6596452fae114291c65935af5bb76d31915..54672e63d5266893cde3f1457557d05cc97e59c9 100644
--- a/base/metrics/field_trial_unittest.cc
+++ b/base/metrics/field_trial_unittest.cc
@@ -342,12 +342,12 @@ TEST_F(FieldTrialTest, AllGroups) {
std::string winner("Winner");
trial->AppendGroup(winner, 10);
EXPECT_TRUE(trial->GetState(&field_trial_state));
- EXPECT_EQ(one_winner, field_trial_state.trial_name);
- EXPECT_EQ(winner, field_trial_state.group_name);
+ EXPECT_EQ(one_winner, *field_trial_state.trial_name);
+ EXPECT_EQ(winner, *field_trial_state.group_name);
trial->group();
EXPECT_TRUE(trial->GetState(&field_trial_state));
- EXPECT_EQ(one_winner, field_trial_state.trial_name);
- EXPECT_EQ(winner, field_trial_state.group_name);
+ EXPECT_EQ(one_winner, *field_trial_state.trial_name);
+ EXPECT_EQ(winner, *field_trial_state.group_name);
std::string multi_group("MultiGroup");
scoped_refptr<FieldTrial> multi_group_trial =
@@ -360,8 +360,8 @@ TEST_F(FieldTrialTest, AllGroups) {
// Finalize the group selection by accessing the selected group.
multi_group_trial->group();
EXPECT_TRUE(multi_group_trial->GetState(&field_trial_state));
- EXPECT_EQ(multi_group, field_trial_state.trial_name);
- EXPECT_EQ(multi_group_trial->group_name(), field_trial_state.group_name);
+ EXPECT_EQ(multi_group, *field_trial_state.trial_name);
+ EXPECT_EQ(multi_group_trial->group_name(), *field_trial_state.group_name);
}
TEST_F(FieldTrialTest, ActiveGroupsNotFinalized) {
« base/metrics/field_trial.cc ('K') | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698