Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: base/metrics/field_trial_unittest.cc

Issue 2633383002: Change FieldTrial::State to not use StringPiece members. (Closed)
Patch Set: Fix initialization in new struct. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/field_trial.h" 5 #include "base/metrics/field_trial.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/base_switches.h" 9 #include "base/base_switches.h"
10 #include "base/build_time.h" 10 #include "base/build_time.h"
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 } 335 }
336 336
337 TEST_F(FieldTrialTest, AllGroups) { 337 TEST_F(FieldTrialTest, AllGroups) {
338 FieldTrial::State field_trial_state; 338 FieldTrial::State field_trial_state;
339 std::string one_winner("One Winner"); 339 std::string one_winner("One Winner");
340 scoped_refptr<FieldTrial> trial = 340 scoped_refptr<FieldTrial> trial =
341 CreateFieldTrial(one_winner, 10, "Default", NULL); 341 CreateFieldTrial(one_winner, 10, "Default", NULL);
342 std::string winner("Winner"); 342 std::string winner("Winner");
343 trial->AppendGroup(winner, 10); 343 trial->AppendGroup(winner, 10);
344 EXPECT_TRUE(trial->GetState(&field_trial_state)); 344 EXPECT_TRUE(trial->GetState(&field_trial_state));
345 EXPECT_EQ(one_winner, field_trial_state.trial_name); 345 EXPECT_EQ(one_winner, *field_trial_state.trial_name);
346 EXPECT_EQ(winner, field_trial_state.group_name); 346 EXPECT_EQ(winner, *field_trial_state.group_name);
347 trial->group(); 347 trial->group();
348 EXPECT_TRUE(trial->GetState(&field_trial_state)); 348 EXPECT_TRUE(trial->GetState(&field_trial_state));
349 EXPECT_EQ(one_winner, field_trial_state.trial_name); 349 EXPECT_EQ(one_winner, *field_trial_state.trial_name);
350 EXPECT_EQ(winner, field_trial_state.group_name); 350 EXPECT_EQ(winner, *field_trial_state.group_name);
351 351
352 std::string multi_group("MultiGroup"); 352 std::string multi_group("MultiGroup");
353 scoped_refptr<FieldTrial> multi_group_trial = 353 scoped_refptr<FieldTrial> multi_group_trial =
354 CreateFieldTrial(multi_group, 9, "Default", NULL); 354 CreateFieldTrial(multi_group, 9, "Default", NULL);
355 355
356 multi_group_trial->AppendGroup("Me", 3); 356 multi_group_trial->AppendGroup("Me", 3);
357 multi_group_trial->AppendGroup("You", 3); 357 multi_group_trial->AppendGroup("You", 3);
358 multi_group_trial->AppendGroup("Them", 3); 358 multi_group_trial->AppendGroup("Them", 3);
359 EXPECT_TRUE(multi_group_trial->GetState(&field_trial_state)); 359 EXPECT_TRUE(multi_group_trial->GetState(&field_trial_state));
360 // Finalize the group selection by accessing the selected group. 360 // Finalize the group selection by accessing the selected group.
361 multi_group_trial->group(); 361 multi_group_trial->group();
362 EXPECT_TRUE(multi_group_trial->GetState(&field_trial_state)); 362 EXPECT_TRUE(multi_group_trial->GetState(&field_trial_state));
363 EXPECT_EQ(multi_group, field_trial_state.trial_name); 363 EXPECT_EQ(multi_group, *field_trial_state.trial_name);
364 EXPECT_EQ(multi_group_trial->group_name(), field_trial_state.group_name); 364 EXPECT_EQ(multi_group_trial->group_name(), *field_trial_state.group_name);
365 } 365 }
366 366
367 TEST_F(FieldTrialTest, ActiveGroupsNotFinalized) { 367 TEST_F(FieldTrialTest, ActiveGroupsNotFinalized) {
368 const char kTrialName[] = "TestTrial"; 368 const char kTrialName[] = "TestTrial";
369 const char kSecondaryGroupName[] = "SecondaryGroup"; 369 const char kSecondaryGroupName[] = "SecondaryGroup";
370 370
371 int default_group = -1; 371 int default_group = -1;
372 scoped_refptr<FieldTrial> trial = 372 scoped_refptr<FieldTrial> trial =
373 CreateFieldTrial(kTrialName, 100, kDefaultGroupName, &default_group); 373 CreateFieldTrial(kTrialName, 100, kDefaultGroupName, &default_group);
374 const int secondary_group = trial->AppendGroup(kSecondaryGroupName, 50); 374 const int secondary_group = trial->AppendGroup(kSecondaryGroupName, 50);
(...skipping 988 matching lines...) Expand 10 before | Expand all | Expand 10 after
1363 1363
1364 // Check that the params match. 1364 // Check that the params match.
1365 std::map<std::string, std::string> shm_params; 1365 std::map<std::string, std::string> shm_params;
1366 entry->GetParams(&shm_params); 1366 entry->GetParams(&shm_params);
1367 EXPECT_EQ(2u, shm_params.size()); 1367 EXPECT_EQ(2u, shm_params.size());
1368 EXPECT_EQ("value1", shm_params["key1"]); 1368 EXPECT_EQ("value1", shm_params["key1"]);
1369 EXPECT_EQ("value2", shm_params["key2"]); 1369 EXPECT_EQ("value2", shm_params["key2"]);
1370 } 1370 }
1371 1371
1372 } // namespace base 1372 } // namespace base
OLDNEW
« no previous file with comments | « base/metrics/field_trial.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698